GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
No description provided.
User Rails 4 find_by
Merge pull request #8989 from robertomiranda/use-rails-4-find-by
Replace deprecated find_by_* with find_by
Is find_by_* really deprecated?
I don't see any deprecation warning for this in my Rails 4 project, and actually it works even if I unbundle activerecord-deprecated_finders gem.
Afaik, find_by_attribute is not deprecated, but find_by_foo_and_bar_and_baz is.
Right. I'm afraid this update is a bit too much.
Actually find_by_id(Model.id) looks (slightly) nicer than find_by(id: Model.id) in terms of readability IMO.
👎 on this, since find_by_[attribute] dynamic finder did not get removed.
Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find…
This reverts commit 637a7d9, reversing
changes made to 5937bd0.