Digest auth should not 500 when given a basic header. #9022

Merged
merged 1 commit into from Mar 18, 2013

Conversation

Projects
None yet
2 participants
@braddunbar
Contributor

braddunbar commented Jan 21, 2013

No description provided.

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Feb 25, 2013

Member

This seems good. Can you please amend the commit to include a CHANGELOG entry please?

Member

steveklabnik commented Feb 25, 2013

This seems good. Can you please amend the commit to include a CHANGELOG entry please?

@braddunbar

This comment has been minimized.

Show comment Hide comment
@braddunbar

braddunbar Feb 25, 2013

Contributor

Sure thing, CHANGELOG entry added above.

Contributor

braddunbar commented Feb 25, 2013

Sure thing, CHANGELOG entry added above.

@braddunbar

This comment has been minimized.

Show comment Hide comment
@braddunbar

braddunbar Mar 18, 2013

Contributor

Ping! @steveklabnik Anything else you need here?

Contributor

braddunbar commented Mar 18, 2013

Ping! @steveklabnik Anything else you need here?

@steveklabnik

View changes

actionpack/test/controller/http_digest_authentication_test.rb
@@ -249,6 +249,14 @@ def authenticate_with_request
assert_equal 'Definitely Maybe', @response.body
end
+ test "basic auth header" do

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 18, 2013

Member

Can you change this to actually describe the result, too? Maybe "when sent a basic auth header, returns Unauthorized"

@steveklabnik

steveklabnik Mar 18, 2013

Member

Can you change this to actually describe the result, too? Maybe "when sent a basic auth header, returns Unauthorized"

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 18, 2013

Member

Also, I need a squash + rebase.

Member

steveklabnik commented Mar 18, 2013

Also, I need a squash + rebase.

@braddunbar

This comment has been minimized.

Show comment Hide comment
@braddunbar

braddunbar Mar 18, 2013

Contributor

Done and done. Thanks!

Contributor

braddunbar commented Mar 18, 2013

Done and done. Thanks!

steveklabnik added a commit that referenced this pull request Mar 18, 2013

Merge pull request #9022 from braddunbar/digest-basic-auth
Digest auth should not 500 when given a basic header.

@steveklabnik steveklabnik merged commit 2a5521e into rails:master Mar 18, 2013

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 18, 2013

Member

Thank you! ❤️

Member

steveklabnik commented Mar 18, 2013

Thank you! ❤️

@braddunbar braddunbar deleted the braddunbar:digest-basic-auth branch Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment