Remove yaml Proc param parser test #9104

Merged
merged 1 commit into from Jan 29, 2013

2 participants

@bemurphy

I don't believe this test is exercising any explicit params_parser
behavior that the other two Proc tests aren't already doing. Given
that we now know it's a bad idea to load user input via YAML.load,
somebody reading this test might get a dangerous idea about building
out a YAML params parser.

@bemurphy bemurphy Remove yaml Proc param parser test
I don't believe this test is exercising any explicit params_parser
behavior that the other two Proc tests aren't already doing.  Given
that we now know it's a bad idea to load user input via YAML.load,
somebody reading this test might get a dangerous idea about building
out a YAML params parser.
c302741
@bemurphy

I just realized it's possible the test is there to exercise this bit of code, still seems a bit dubious though.

Edit: Though, that test passes if I comment out the referenced line so, probably not.

@carlosantoniodasilva carlosantoniodasilva merged commit 29000a7 into rails:master Jan 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment