Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't call after_commit when creating through an association and save fails, fixes #5802 #9115

Merged
merged 1 commit into from Feb 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

bensie commented Jan 29, 2013

As described in #5802, when creating through an association using a non-bang create, if the create fails for some reason, after_commit is still called.

Member

steveklabnik commented Feb 13, 2013

This looks fine to me, but we do need a CHANGELOG entry please. Just roll that into the first commit.

steveklabnik added a commit that referenced this pull request Feb 13, 2013

Merge pull request #9115 from bensie/issue_5802
Don't call after_commit when creating through an association and save fails, fixes #5802

@steveklabnik steveklabnik merged commit f36b80b into rails:master Feb 13, 2013

Member

steveklabnik commented Feb 13, 2013

Thank you! Sorry again it took me a while to review ❤️

Contributor

bensie commented Feb 13, 2013

No problem at all! You're awesome.

@bensie bensie deleted the bensie:issue_5802 branch Feb 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment