New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding database extension support to schema.rb #9203

Merged
merged 3 commits into from Feb 7, 2013

Conversation

Projects
None yet
2 participants
@jaggederest
Contributor

jaggederest commented Feb 7, 2013

Fixes issue #9193

I could use some extra eyeballs and feedback on this, I'm not entirely familiar with the schema dumper.

Thanks for your time

jaggederest added some commits Feb 6, 2013

improve tests to check for existence of extensions method, and skip t…
…esting dumped extensions if they are unsupported by the database
add ActiveRecord::AbstractAdapter#extensions and ActiveRecord::Connec…
…tionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb

tenderlove added a commit that referenced this pull request Feb 7, 2013

Merge pull request #9203 from jaggederest/dumping_pgsql_extensions
Adding database extension support to schema.rb

@tenderlove tenderlove merged commit 34ac46c into rails:master Feb 7, 2013

@jaggederest jaggederest deleted the jaggederest:dumping_pgsql_extensions branch Feb 7, 2013

tenderlove added a commit that referenced this pull request Feb 8, 2013

Merge branch 'master' into jobs
* master:
  Skip schema dumper extensions test if connection does not support it
  active_record: Quote numeric values compared to string columns.
  Run schema dumper extensions without creating real extensions
  Do not print anything related to extensions when they don't none exist
  Add blank line after extensions to separate from tables in schema
  Fix indentation of extensions in schema
  Call super to use the abstract adapter implementation instead
  Add changelog entry for #9203 about schema dumper with db extensions
  add ActiveRecord::AbstractAdapter#extensions and ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb
  improve tests to check for existence of extensions method, and skip testing dumped extensions if they are unsupported by the database
  Add some tests to enumerate how extensions should be stored in the schema output
  Update changelog from #9128 with author name
  Update actionpack/CHANGELOG.md
  ruby constant syntax is not supported as routing `:controller` option.
  Fix article for generator name
  Update .gitignore
  Enable hstore extensions on tests if it is not enabled and database supports it
  Ignore .ruby-version
  Modify TimeWithZone#as_json to return 3DP of sub-second accuracy by default, since it's allowed by the spec and is very useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment