Remove XML Parser from ActionDispatch

[sikachu]

As per our discussion, this is going to be extracted out to a gem. If you want an ability to parse XML parameters, please install actiondispatch-xml_params_parser actionpack-xml_parser gem.

[steveklabnik]

👍

[haileys]

👍

[homakov]

I cannot see a merge button? Anyone, if you see the "merge" button, click, ASAP

[sikachu]

Holding this one off right now to discuss the right gem name for this. Potential candidates are:

1. actiondispatch-xml_params_parser
2. action_dispatch-xml_params_parser
3. actionpack-xml_params_parser

I like 2 myself, since it follows Ruby require convention.

[steveklabnik]

My vote is blue...errr, 3, because it's extending the actionpack gem.

[carlosantoniodasilva]

3 👍

[mdespuits]

Yeah, 3 👍

[xiaods]

yeah. 3 👍

[sikachu]

Vote closed, and now I'm having a facepalm moment.

You could say that it's extending actionpack, but then you also have to think that actionpack is actually consist of abstract_controller, action_controller, action_dispatch, and action_view. actionpack itself is a container ...

I'm writing a documentation for ActionDispatch::XmlParamsParser now, and it doesn't make sense if the gem is going to be named actionpack-xml_params_parser. Also, if I renamed the namespace to ActionPack::XmlParamsParser, it started to feel weird as well.

Can I use my veto power and do 2?

[frodsan]

btw,

https://github.com/rails/actionpack-action_caching
https://github.com/rails/actionpack-page_caching

[sikachu]

I see. So I guess it should be in actionpack prefix. nvm then.

[xiaods]

@sikachu how about your choice?

[sikachu]

We've decided that we'll go with actionpack-xml_parser. A bit shorter, while keeping the gem within actionpack- prefix.

[sikachu]

Code update mentioning the new library name. The code also has been extracted to https://github.com/rails/actionpack-xml_parser

[nicolai86]

👍

[rafaelfranca]

Is something missing?

[sikachu]

I think this is ready, and the green button is appearing again ... click it!

[rafaelfranca]

Thank you @guilleiguaran @sikachu