Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Access an instance's connection via its class, rather than via #connection #9371
Had a problem today where we had a
Discovered the root cause was this method, which was attempting to call
I experimented with removing the connection instance method from core and these were the only other places in the codebase that seemed to rely on it:
It seems like it only makes sense to try to make the earlier change if I change all these others as well, otherwise it'll only be a matter of time until they likely bite me or someone else. Do you think this is worthwhile? It still seems like it's going to be hard to protect against others introducing new code that relies on it, the only sure-fire way to remove it as a 'reserved method' would be to rename it or remove it entirely, but both of those seem like too big of changes to the AR interface.