Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --builder option from rails command #9401

Merged
merged 1 commit into from
Feb 24, 2013

Conversation

sikachu
Copy link
Member

@sikachu sikachu commented Feb 24, 2013

Ability to use a custom builder by passing --builder (or -b) has been removed. Consider using application template instead. See this guide for more detail: http://guides.rubyonrails.org/rails_application_templates.html

@sikachu
Copy link
Member Author

sikachu commented Feb 24, 2013

sure!

@sikachu
Copy link
Member Author

sikachu commented Feb 24, 2013

PR updated.

@sikachu
Copy link
Member Author

sikachu commented Feb 24, 2013

whoops, hold on

@rafaelfranca
Copy link
Member

Missing to remove the methods in my last comment

Ability to use a custom builder by passing `--builder` (or `-b`) has
been removed. Consider using application template instead. See this
guide for more detail:
http://guides.rubyonrails.org/rails_application_templates.html
@sikachu
Copy link
Member Author

sikachu commented Feb 24, 2013

I ended up removed the whole class, since it's now a no-op.

rafaelfranca added a commit that referenced this pull request Feb 24, 2013
Remove `--builder` option from `rails` command
@rafaelfranca rafaelfranca merged commit bce6cbd into rails:master Feb 24, 2013
@rafaelfranca
Copy link
Member

❤️ 💚 💙 💛 💜

@sikachu sikachu deleted the master-remove-builder-option branch February 24, 2013 19:37
@DamirSvrtan
Copy link

what @jokklan said +1. @sikachu why is this feature removed? Thnx!

@sikachu
Copy link
Member Author

sikachu commented Aug 11, 2014

I'll let core team speak on this one (/cc @dhh). I think we didn't see enough usage on this in the real world, so it got removed during the cleanup.

@dhh
Copy link
Member

dhh commented Aug 12, 2014

I've never used this, so I'd need some context as to what this is used for to chime in. Can anyone give some real-world examples of how and for what they're using this?

@jokklan
Copy link

jokklan commented Aug 18, 2014

I have two cases where i used it myself: Dummy app for testing (which is generated when generating a new engine, but their does not exists any rake method to create it manually), and custom engines.

RefineryCMS is another good example where they have created a whole new custom generator for engines, instead of using all the methods already available in the internal Rails engine builder (see: engine_generator.rb and extension_generator.rb).

@jokklan
Copy link

jokklan commented Aug 18, 2014

Another solution would be to make it simpler to make a generator with a custom builder that inherits from the existing builders, and add documentation about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants