Allow both a path and an option on root in config/routes #9441

Merged
merged 1 commit into from Feb 26, 2013

4 participants

@rubys

This is a small thing, motivated by #9419

In the scenario in Agile Web Development with Rails, I ask the reader to add an as: 'store' to the root line in config/routes. The problem is that root as currently defined only accepts one parameter. I can suggest that they add to: to the front, but that's not easily discoverable. A better solution would be to accept both a path and an option string and to combine them.

@guilleiguaran guilleiguaran merged commit b1dee8c into rails:master Feb 26, 2013
@frodsan

@guilleiguaran Are you sure this doesn't need tests?

@guilleiguaran
Ruby on Rails member

@frodsan yes, missed it 😁, do you want to go ahead and add test for this? 😁

@frodsan frodsan pushed a commit that referenced this pull request Feb 26, 2013
Francesco Rodriguez Add tests for #9441 7487e79
@rubys

For completeness, should this have a CHANGELOG entry? :-)

@rafaelfranca
Ruby on Rails member

Confirm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment