Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

`Connection#structure_dump` is no longer used #9538

Merged
merged 2 commits into from Mar 6, 2013

Conversation

Projects
None yet
3 participants
Member

senny commented Mar 4, 2013

Origin: #9518

As of ccc6910 we use mysqldump to create the structure.sql.
The old #structure_dump code is still in AR but never used.

I removed all relevant parts from the code-base.

Even though this is just a cleanup I added a CHANGELOG entry. There could be gem authors or app owners that used #structure_dump, which will no longer be available.

I've also added a commit to issue a warning when mysqldump is not in the PATH. The rake task used to fail silently and left an empty structure.sql, which is not very helpful.

Member

senny commented Mar 4, 2013

@rafaelfranca @carlosantoniodasilva can you take a look?

senny added some commits Mar 4, 2013

@senny senny `Connection#structure_dump` is no longer used. #9518
As of ccc6910 we use `mysqldump` to create the `structure.sql`.
The old `#structure_dump` code is still in AR but never used.

I removed all relevant parts from the code-base.
854b742
@senny senny rake db:structure:dump warns when `mysqldump` is not in PATH.
Closes #9518.

The rake task used to fail silently and left an empty `structure.sql`.
It's confusing for users to get to the root of the problem.
The warning message tells them where to look.
0a5fdcd

@rafaelfranca rafaelfranca added a commit that referenced this pull request Mar 6, 2013

@rafaelfranca rafaelfranca Merge pull request #9538 from senny/remove_structure_dump
`Connection#structure_dump` is no longer used
a8bc72e

@rafaelfranca rafaelfranca merged commit a8bc72e into rails:master Mar 6, 2013

@senny senny deleted the senny:remove_structure_dump branch Mar 6, 2013

@rochefort rochefort commented on the diff Mar 12, 2013

activerecord/CHANGELOG.md
@@ -1,5 +1,13 @@
## Rails 4.0.0 (unreleased) ##
+* Warn when `rake db:structure:dump` with a mysl database and
@rochefort

rochefort Mar 12, 2013

Contributor

'mysl' is a typo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment