Use gsub intead of tr when the to_str is longer than the from_str #9573

Merged
merged 1 commit into from Mar 5, 2013

Projects

None yet

3 participants

@guilleiguaran guilleiguaran merged commit 9e43ce5 into rails:master Mar 5, 2013
@rafaelfranca
Member

We will need tests to ensure this will not occur anymore

@guilleiguaran
Member

@rafaelfranca 👍 sure, I merged the first one after of verify that all AP tests were passing

@robertomiranda

@rafaelfranca I'll add test for that

@robertomiranda robertomiranda deleted the robertomiranda:useless_gsub branch Mar 5, 2013
@robertomiranda robertomiranda referenced this pull request Mar 5, 2013
Merged

Add DebugHelperTest #9574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment