Typo in comment to ActionView::Resolver#find_all #9585

Merged
merged 1 commit into from Mar 6, 2013

Projects

None yet

2 participants

@RKushnir
Contributor
RKushnir commented Mar 6, 2013

No description provided.

@carlosantoniodasilva carlosantoniodasilva merged commit ac13b4d into rails:master Mar 6, 2013
@carlosantoniodasilva

Thanks. Just as a side note, you can push doc fixes freely to https://github.com/lifo/docrails, it's an open branch of Rails for documentation purposes, that's cross-merged with Rails master from time to time. All commits there are reviewed the same way and copy edited if necessary before being merged.

@RKushnir
Contributor
RKushnir commented Mar 6, 2013

Thanks, I didn't know. It's just easier to use the github's quick fork feature to edit and send small pull requests right from the site. Is it the preferable way to use lifo/docrails?

@RKushnir RKushnir deleted the unknown repository branch Mar 6, 2013
@carlosantoniodasilva

@RKushnir for docs it's usually preferable to go with lifo/docrails, but there's no problem in sending them as pull requests here, as long as you are contributing fixes, we are all happy :).

Another thing just came to my mind: when contributing doc patches, it's usually good to add [ci skip] to the commit message, so we skip running tests in travis ci. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment