Use AS::Notifications to instrument Strong Params #9626

merged 1 commit into from Mar 9, 2013


None yet
3 participants

dasch commented Mar 9, 2013

This pull request decouples Parameters from the actual logging, instead using a LogSubscriber for that. Since ActiveSupport::Notifications is used, it is trivial to add other subscribers if needed. I'd like to add a Statsd subscriber in one of my own apps in order to monitor the frequency of unpermitted param injection attempts, but many other uses seem possible.

It would be nice to include the controller and action in the event payload, but that would require a larger change. If you guys deem it desirable I would be happy to do it.


senny commented Mar 9, 2013

I like this change. Could you include a CHANGELOG entry and a test-case?

josevalim added a commit that referenced this pull request Mar 9, 2013

Merge pull request #9626 from dasch/dasch/instrument-strong-params
Use AS::Notifications to instrument Strong Params

@josevalim josevalim merged commit 6a18ec0 into rails:master Mar 9, 2013


josevalim commented Mar 9, 2013

Merged. I don't think we need a CHANGELOG entry here, it is a small change. We should keep the most important changes in the CHANGELOG, people can always check the commits for more info. :)

@dasch dasch deleted the dasch:dasch/instrument-strong-params branch Mar 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment