Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Date#all_week/month/quarter/year for generating date ranges #9685

Merged
merged 1 commit into from Dec 3, 2013

Conversation

@dmeremyanin
Copy link
Contributor

@dmeremyanin dmeremyanin commented Mar 12, 2013

Similar to Time#all_* methods, but with dates.

@carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Mar 12, 2013

I think it makes sense, but it needs a changelog entry. Thanks.

@dmeremyanin
Copy link
Contributor Author

@dmeremyanin dmeremyanin commented Mar 12, 2013

Added missing changelog entry.

@dmeremyanin dmeremyanin reopened this Mar 15, 2013
@dmeremyanin
Copy link
Contributor Author

@dmeremyanin dmeremyanin commented Mar 15, 2013

Sorry, closed accidentally.
@carlosantoniodasilva can you review this again, please?

@JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Apr 30, 2013

Hey @carlosantoniodasilva did you ever get a chance to re-review this?

@carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Dec 3, 2013

I'll get back to it soon, sorry.

@carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Dec 3, 2013

@dimko can you rebase it? Might have a changelog conflict. Thanks.

@dmeremyanin
Copy link
Contributor Author

@dmeremyanin dmeremyanin commented Dec 3, 2013

carlosantoniodasilva added a commit that referenced this pull request Dec 3, 2013
Added Date#all_week/month/quarter/year for generating date ranges
@carlosantoniodasilva carlosantoniodasilva merged commit c55200c into rails:master Dec 3, 2013
@carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Dec 3, 2013

There we go, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.