New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Date#all_week/month/quarter/year for generating date ranges #9685

Merged
merged 1 commit into from Dec 3, 2013

Conversation

Projects
None yet
3 participants
@dmeremyanin
Contributor

dmeremyanin commented Mar 12, 2013

Similar to Time#all_* methods, but with dates.

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Mar 12, 2013

Member

I think it makes sense, but it needs a changelog entry. Thanks.

Member

carlosantoniodasilva commented Mar 12, 2013

I think it makes sense, but it needs a changelog entry. Thanks.

@dmeremyanin

This comment has been minimized.

Show comment
Hide comment
@dmeremyanin

dmeremyanin Mar 12, 2013

Contributor

Added missing changelog entry.

Contributor

dmeremyanin commented Mar 12, 2013

Added missing changelog entry.

@dmeremyanin dmeremyanin reopened this Mar 15, 2013

@dmeremyanin

This comment has been minimized.

Show comment
Hide comment
@dmeremyanin

dmeremyanin Mar 15, 2013

Contributor

Sorry, closed accidentally.
@carlosantoniodasilva can you review this again, please?

Contributor

dmeremyanin commented Mar 15, 2013

Sorry, closed accidentally.
@carlosantoniodasilva can you review this again, please?

@JonRowe

This comment has been minimized.

Show comment
Hide comment
@JonRowe

JonRowe Apr 30, 2013

Contributor

Hey @carlosantoniodasilva did you ever get a chance to re-review this?

Contributor

JonRowe commented Apr 30, 2013

Hey @carlosantoniodasilva did you ever get a chance to re-review this?

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Dec 3, 2013

Member

I'll get back to it soon, sorry.

Member

carlosantoniodasilva commented Dec 3, 2013

I'll get back to it soon, sorry.

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Dec 3, 2013

Member

@dimko can you rebase it? Might have a changelog conflict. Thanks.

Member

carlosantoniodasilva commented Dec 3, 2013

@dimko can you rebase it? Might have a changelog conflict. Thanks.

@dmeremyanin

This comment has been minimized.

Show comment
Hide comment
@dmeremyanin
Contributor

dmeremyanin commented Dec 3, 2013

carlosantoniodasilva added a commit that referenced this pull request Dec 3, 2013

Merge pull request #9685 from dimko/patch-2
Added Date#all_week/month/quarter/year for generating date ranges

@carlosantoniodasilva carlosantoniodasilva merged commit c55200c into rails:master Dec 3, 2013

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Dec 3, 2013

Member

There we go, thanks!

Member

carlosantoniodasilva commented Dec 3, 2013

There we go, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment