Removed trailing white space from all files in actionmailer +activemodels dirs. #9736

Closed
wants to merge 1 commit into
from

5 participants

@jasnow

Removed trailing white space from all files in actionmailer and
activemodel directories; ran rake before and after (same results).
Other directories were not clean enough (test-wise) so deferred.

@sqctest02 sqctest02 Removed trailing white space from all files in actionmailer and activ…
…emodel directories; ran rake before and after (same)
98b01da
@wangjohn

Usually only rails committers make these types of cosmetic changes. Also this might obscure the commit history, although its probably fine to get rid of the newlines.

@steveklabnik
Ruby on Rails member

Yes, we don't make these kinds of changes for the reasons @wangjohn commented. If you were fixing this area of the codebase, removing them would be great.

Thank you for the patch, but I can't accept it.

@jasnow

You should change the documentation to state the above policy. I followed Section 6.3 of http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html bullet #2.

@rafaelfranca
Ruby on Rails member

The policy is still the same, we just do not accept pull requests doing only this.

@rafaelfranca
Ruby on Rails member

Yes. In the section 6.2 you can see:

Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted.

@jasnow

Found it - thanks. Bye.

@jasnow jasnow deleted the unknown repository branch Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment