Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix typos in AR. lots of them. #9778

Merged
merged 1 commit into from

2 participants

@vipulnsward

Try fixing some of AR typos

@steveklabnik steveklabnik merged commit bfdd3c2 into rails:master
@steveklabnik
Collaborator

Thank you! :heart:

In the future, feel free to push the comment changes to lifo/docrails, which is a fast-track for documentation changes. Anything that touches code, even typo fixes, should go through a pull request, though, so :+1:

@vipulnsward vipulnsward deleted the vipulnsward:fix_typos_in_ar_v1 branch
@vipulnsward

Thanks @steveklabnik I do push documentation changes to lifo/docrails, this had changes to code, so pushed here.

@steveklabnik
Collaborator

Absolutely, this was 100% right, I just wanted to mention in case you didn't know. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 18, 2013
  1. @vipulnsward
This page is out of date. Refresh to see the latest.
View
2  activerecord/lib/active_record/attribute_methods.rb
@@ -21,7 +21,7 @@ module ClassMethods
# Generates all the attribute related methods for columns in the database
# accessors, mutators and query methods.
def define_attribute_methods # :nodoc:
- # Use a mutex; we don't want two thread simaltaneously trying to define
+ # Use a mutex; we don't want two thread simultaneously trying to define
# attribute methods.
@attribute_methods_mutex.synchronize do
return if attribute_methods_generated?
View
2  activerecord/lib/active_record/connection_adapters/abstract/database_limits.rb
@@ -21,7 +21,7 @@ def table_name_length
# limit is enforced by rails and Is less than or equal to
# <tt>index_name_length</tt>. The gap between
# <tt>index_name_length</tt> is to allow internal rails
- # opreations to use prefixes in temporary opreations.
+ # operations to use prefixes in temporary operations.
def allowed_index_name_length
index_name_length
end
View
2  activerecord/lib/active_record/connection_adapters/abstract/transaction.rb
@@ -78,7 +78,7 @@ def initialize(connection, parent, options = {})
@joinable = options.fetch(:joinable, true)
end
- # This state is necesarry so that we correctly handle stuff that might
+ # This state is necessary so that we correctly handle stuff that might
# happen in a commit/rollback. But it's kinda distasteful. Maybe we can
# find a better way to structure it in the future.
def finishing?
View
2  activerecord/lib/active_record/explain.rb
@@ -9,7 +9,7 @@ def collecting_queries_for_explain # :nodoc:
yield
return current[:available_queries_for_explain]
ensure
- # Note that the return value above does not depend on this assigment.
+ # Note that the return value above does not depend on this assignment.
current[:available_queries_for_explain] = original
end
View
2  activerecord/test/cases/associations/eager_test.rb
@@ -193,7 +193,7 @@ def test_finding_with_includes_on_has_many_association_with_same_include_include
end
end
- def test_finding_with_includes_on_has_one_assocation_with_same_include_includes_only_once
+ def test_finding_with_includes_on_has_one_association_with_same_include_includes_only_once
author = authors(:david)
post = author.post_about_thinking_with_last_comment
last_comment = post.last_comment
View
4 activerecord/test/cases/attribute_methods_test.rb
@@ -159,8 +159,8 @@ def test_array_content
end
def test_read_attributes_before_type_cast
- category = Category.new({:name=>"Test categoty", :type => nil})
- category_attrs = {"name"=>"Test categoty", "id" => nil, "type" => nil, "categorizations_count" => nil}
+ category = Category.new({:name=>"Test category", :type => nil})
+ category_attrs = {"name"=>"Test category", "id" => nil, "type" => nil, "categorizations_count" => nil}
assert_equal category_attrs , category.attributes_before_type_cast
end
View
2  activerecord/test/cases/batches_test.rb
@@ -11,7 +11,7 @@ def setup
Post.count('id') # preheat arel's table cache
end
- def test_each_should_excecute_one_query_per_batch
+ def test_each_should_execute_one_query_per_batch
assert_queries(Post.count + 1) do
Post.find_each(:batch_size => 1) do |post|
assert_kind_of Post, post
View
2  activerecord/test/cases/dup_test.rb
@@ -110,7 +110,7 @@ def test_dup_after_initialize_callbacks
def test_dup_validity_is_independent
repair_validations(Topic) do
Topic.validates_presence_of :title
- topic = Topic.new("title" => "Litterature")
+ topic = Topic.new("title" => "Literature")
topic.valid?
duped = topic.dup
View
2  activerecord/test/cases/nested_attributes_test.rb
@@ -167,7 +167,7 @@ def test_reject_if_with_blank_nested_attributes_id
def test_first_and_array_index_zero_methods_return_the_same_value_when_nested_attributes_are_set_to_update_existing_record
Man.accepts_nested_attributes_for(:interests)
man = Man.create(:name => "John")
- interest = man.interests.create :topic => 'gardning'
+ interest = man.interests.create :topic => 'gardening'
man = Man.find man.id
man.interests_attributes = [{:id => interest.id, :topic => 'gardening'}]
assert_equal man.interests.first.topic, man.interests[0].topic
Something went wrong with that request. Please try again.