Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add router DSL to explicitly match all verbs #9840

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

trliner commented Mar 20, 2013

This commit allows calling +match+ with a :via => :all option to explicitly match all verbs.

The :via => :all option was added to Rails 4 in the process of deprecating +match+ (#5964). To facilitate the migration to Rails 4, it would be helpful to make this option available in Rails 3.

@trliner trliner Add router DSL to explicitly match all verbs
This commit allows calling +match+ with a
:via => :all option to explicitly match all verbs.

The :via => :all option was added to Rails 4 in
the  process of deprecating +match+ (#5964). To
facilitate the migration to Rails 4, it would be
helpful to make this option available in Rails 3.
c419cff

I think I'd rather not have this option in Rails 3, so that people can consciously choose whether they're really needing a get/post VS allowing to match all. By adding this option, we'd opening the ports for everyone to change match to match all to solve the problem, and the overall idea of not allowing match with a specific verb/verbs would be kinda useless I think. Just my cents about the change, lets get other feedback before acting. Thanks for your contribution.

Member

neerajdotname commented Mar 23, 2013

+1 to what @carlosantoniodasilva said .

Owner

guilleiguaran commented Mar 23, 2013

Sorry but we don't backport features from master to stable versions, 3.2.x is only receiving bug fixes.

Thanks for you contribution!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment