Introduce test on Error#full_message for attribute with underscores; Fix... #9864

Merged
merged 1 commit into from Mar 25, 2013

Conversation

Projects
None yet
3 participants
@vipulnsward
Member

vipulnsward commented Mar 22, 2013

  1. Introduce test on Error#full_message for attribute with underscores
  2. Fix typo in test names
@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Mar 22, 2013

Member

Why is the new test relevant? Was there a change in behavior regarding attributes with underscores? Is it to prevent regressions?

Also it would be great if you could shorten your commit message. Github does not like long commit messages. You can always do a short description on the first line, then a blank line and then add a detailed description.

Member

senny commented Mar 22, 2013

Why is the new test relevant? Was there a change in behavior regarding attributes with underscores? Is it to prevent regressions?

Also it would be great if you could shorten your commit message. Github does not like long commit messages. You can always do a short description on the first line, then a blank line and then add a detailed description.

@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward Mar 22, 2013

Member

About the comments: Will keep in mind the next time

While scanning through Error model, I found the tr(".","_") and humanize on the result in full_messages.

The behaviour for having _ in the name is different than having a .

Ex:
Model.nestedattr => Model nestedattr
but model_test maps to model_test itself

Test for previous behaviour is present the latter isn't, so added the test.

Member

vipulnsward commented Mar 22, 2013

About the comments: Will keep in mind the next time

While scanning through Error model, I found the tr(".","_") and humanize on the result in full_messages.

The behaviour for having _ in the name is different than having a .

Ex:
Model.nestedattr => Model nestedattr
but model_test maps to model_test itself

Test for previous behaviour is present the latter isn't, so added the test.

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Mar 22, 2013

Member

I see.

Regarding the commit message, you can easily update it by using git commit --amend or git rebase -i and then issue a force push on your branch fix_test_AR_v2. The PR on Github will reflect the changes automatically.

Member

senny commented Mar 22, 2013

I see.

Regarding the commit message, you can easily update it by using git commit --amend or git rebase -i and then issue a force push on your branch fix_test_AR_v2. The PR on Github will reflect the changes automatically.

@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward Mar 22, 2013

Member

@senny updating in some time

Member

vipulnsward commented Mar 22, 2013

@senny updating in some time

Add Error#full_message test; Fix typos
Introduce test on Error#full_message for attribute with underscores; Fix
some typos
@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward Mar 22, 2013

Member

Fixed message

Member

vipulnsward commented Mar 22, 2013

Fixed message

@vipulnsward

This comment has been minimized.

Show comment
Hide comment

rafaelfranca added a commit that referenced this pull request Mar 25, 2013

Merge pull request #9864 from vipulnsward/fix_test_AR_v2
Introduce test on Error#full_message for attribute with underscores; Fix...

@rafaelfranca rafaelfranca merged commit ba012fa into rails:master Mar 25, 2013

@vipulnsward vipulnsward deleted the vipulnsward:fix_test_AR_v2 branch Feb 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment