Skipping test for OpenSSL::PKCS5 JRuby #9874

Merged
merged 1 commit into from Mar 25, 2013

Projects

None yet

4 participants

@arunagw
Ruby on Rails member

As we are doing same as https://github.com/rails/rails/blob/master/activesupport/test/key_generator_test.rb#L3-L8

We need to wait this to be fixed. Can be removed later.

@arunagw
Ruby on Rails member

I ment we need to wait OpenSSL::PKCS5 to be fixed.

@carlosantoniodasilva carlosantoniodasilva commented on an outdated diff Mar 24, 2013
actionpack/test/dispatch/cookies_test.rb
@@ -1,4 +1,13 @@
require 'abstract_unit'
+
+begin
+ require 'openssl'
+ OpenSSL::PKCS5
+rescue LoadError, NameError
+ $stderr.puts "Skipping KeyGenerator test: broken OpenSSL install"
+else
+
+
@arunagw
Ruby on Rails member

Updated :-)

@rafaelfranca rafaelfranca merged commit 7219c5f into rails:master Mar 25, 2013
@arunagw arunagw deleted the arunagw:skipping-test-for-openssl-pkcs5 branch Mar 26, 2013
@claudiob

Hello @arunagw !

I know this is a long shot but… do you remember why this begin/rescue was needed in the first place?
In other words, in which case OpenSSL::PKCS5 might raise an error?

I've seen the same type of code was introduced in def2ccb, 35598db and a6a0904 and the only hint I got is that it might be related to JRuby. Does that ring a bell?

I have a feeling we can safely remove the begin/rescue and Travis CI would still be happy, but I'd like to know your opinion first. Thanks! 🍭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment