`#determine_constant_from_test_name` does not swallow NoMethodErrors. #9946

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

senny commented Mar 27, 2013

Closes #9933.

Since NoMethodError is a subclass of NameError determining
the constant from a test name silently swalled them.

@senny senny `#determine_constant_from_test_name` does not swallow NoMethodErrors.
Closes #9933.

Since `NoMethodError` is a subclass of `NameError` determining
the constant from a test name silently swalled them.
54645da

@carlosantoniodasilva carlosantoniodasilva commented on the diff Mar 27, 2013

activesupport/CHANGELOG.md
@@ -1,5 +1,10 @@
## Rails 4.0.0 (unreleased) ##
+* `#determine_constant_from_test_name` does not swallow NoMethodErrors.
+ Fixes #9933.
+
+ *Yves Senn*.
@carlosantoniodasilva

carlosantoniodasilva Mar 27, 2013

Owner

I think it may not be worth a changelog entry for this fix, wdyt? Makes sense?

Owner

fxn commented Mar 27, 2013

Hey, we are discussing in Campfire.

Owner

fxn commented Mar 28, 2013

Applied in 341e611 by hand.

fxn closed this Mar 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment