Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Changed if ! to unless #9953

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Changed if ! to unless for more readability

Owner

rafaelfranca commented Mar 27, 2013

This fall in the cosmetic changes and we prefer to not accept they.

Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted.

http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#write-your-code

Thank you for the pull request.

@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:AR-unless branch Mar 27, 2013

@rafaelfranca Ah. I missed this before this PR.
cool 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment