fixes for association doc #9998

Merged
merged 2 commits into from Mar 29, 2013

Conversation

Projects
None yet
2 participants
@neerajdotname
Member

neerajdotname commented Mar 29, 2013

No description provided.

steveklabnik added a commit that referenced this pull request Mar 29, 2013

@steveklabnik steveklabnik merged commit b22ec86 into rails:master Mar 29, 2013

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 29, 2013

Member

Thank you! Don't forget that you can push these kinds of changes to lifo/docrails!

Member

steveklabnik commented Mar 29, 2013

Thank you! Don't forget that you can push these kinds of changes to lifo/docrails!

@neerajdotname

This comment has been minimized.

Show comment Hide comment
@neerajdotname

neerajdotname Mar 29, 2013

Member

thanks @steveklabnik . I push changes to guide to lifo/docrails. But for code comments my self imposed rule is to send PR so that any mistake can be caught. You are right. For minor changes in comments I should push to docrails directly.

Member

neerajdotname commented Mar 29, 2013

thanks @steveklabnik . I push changes to guide to lifo/docrails. But for code comments my self imposed rule is to send PR so that any mistake can be caught. You are right. For minor changes in comments I should push to docrails directly.

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 29, 2013

Member

You always can open a pull request if you want, that's fine. I just wanted to make sure that you knew it existed! I'll check you off of my mental list. :)

Member

steveklabnik commented Mar 29, 2013

You always can open a pull request if you want, that's fine. I just wanted to make sure that you knew it existed! I'll check you off of my mental list. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment