HTTPS clone URL
Subversion checkout URL
November 18, 2015 – November 25, 2015
Excluding merges, 48 authors have pushed 40 commits to master and 120 commits to all branches. On master, 70 files have changed and there have been 793 additions and 442 deletions.
37 Pull requests merged by 30 people
- Merged #22401 Remove <br> from scaffold form, in favor of using CSS
- Merged #22290 do not show Active Job test generator
- Merged #22399 Remove unused code
- Merged #22348 Fix wrong timezone mapping for Switzerland (no deprecation warn) 
- Merged #22370 Remove a blank line from a template for plugin `routes.rb`
- Merged #22304 Add schema dumping support for PostgreSQL geometric data types
- Merged #22214 Not passing `native_database_types` to `TableDefinition`
- Merged #22172 Add text template for source code
- Merged #22120 Refactor ActionMailer::Base
- Merged #22287 Move the desc one level up
- Merged #22390 Remove valgrind note about linux only support
- Merged #22272 don't package test files in plugin gemspec
- Merged #22388 `set_field_encoding` is only needed for `MysqlAdapter`
- Merged #21000 Update and fix forbidden attributes test issues caused by AC::Parameters change
- Merged #22385 Test if each_object(singleton_class) works, since JRuby added it.
- Merged #17013 Fix improper value types used to instantiate a Template in AV::NullResol...
- Merged #17928 remove unused `#form_data?`
- Merged #18446 ActionMailer::Base can unregister interceptor(s).
- Merged #22372 Clearer comment and variable name on IP spoofing
- Merged #22374 Simplify `RailsGuides::Generator#select_only` a bit
- Merged #22379 [ci skip] Add `Translating Rails Guides` to contributing_to_ruby_on_r…
- Merged #22383 MySQL 5.7 support for 4-2-stable
- Merged #22380 Fix race condition testing for job execution order
- Merged #21615 Removed Mocha from Action View
- Merged #22333 [ci skip] Update dirty.rb: documentation fix.
- Merged #22362 Add example for AR::Persistence#toggle
- Merged #22353 Add missing example for cookies.encrypted [ci skip]
- Merged #22354 Example of setting data attributes for image_tag
- Merged #22355 Remove arity check for `RouteSet#draw`
- Merged #22332 add deprecations for a smooth transition after #22215
- Merged #22347 Fix test failure in `adapters/mysql/active_schema_test.rb`
- Merged #22336 Change Enumerable#sum to use inject(:sym) specification
- Merged #22322 Backport: Cache url_helpers instead of creating each time
- Merged #22340 Change configuration-guide example
- Merged #22342 Fix a typo
- Merged #22077 Remove newlines from start of logs
- Merged #22338 [ci skip] Indentation in API app guide
18 Pull requests proposed by 16 people
- Proposed #22343 Modify unscoped usage guide to include chaining [ci skip]
- Proposed #22345 Fix rake db:structure:dump on Postgres when multiple schemas are used
- Proposed #22351 Let enqueue options[:wait] be competible with string
- Proposed #22361 rescue memcached errors in a consistent way
- Proposed #22363 Remove some bind related test cases from finder_test.rb to sanitize_t…
- Proposed #22365 Fixed `where` for polymorphic associations when passed an array containing different types.
- Proposed #22366 Speed up asset_path method
- Proposed #22367 Adding Enums section to AR Querying.
- Proposed #22369 Add :except option to validations
- Proposed #22371 Brush up errors of `ActionDispatch::Routing::Mapper#mount`
- Proposed #22373 Add `Routing` namespace to point appropriate constant
- Proposed #22381 Use adapter supports_datetime_with_precision
- Proposed #22391 Associate a new parent record with children
- Proposed #22394 Updated the guides for having a distinct has_many through at the data…
- Proposed #22395 `ActiveRecord::Base#becomes` should copy the errors
- Proposed #22402 Reset PATH_INFO between ActionController tests
- Proposed #22409 Use the hash syntax in the order clause in `in_batches`
- Proposed #22411 Docs: ActiveRecord::QueryMethods#joins
20 Issues closed by 9 people
- Closed #22410 ActiveJob is using the object's old `updated_at` value...
- Closed #22397 ActiveRecord 4.2.5 issue with Ruby 1.9.3 (Psych::Coder)
- Closed #22233 Wrong timezone mapping for Switzerland
- Closed #22393 ActionController::TestCase#process(action, *args) throwing TypeError: no implicit conversion of Symbol into Integer when passing a JSON string as request body and specifying :format as :json
- Closed #22376 Improve subclasses/descendants performance by using JRuby ext
- Closed #22384 Nested relations builds incorrect SQL
- Closed #22382 Rails 4.1.0 ActiveRecord Test Database Schema Question
- Closed #22377 In the Guides "association_basics", i have a question .
- Closed #22375 rubyonrails getting started guide NoMethodError in Articles#index
- Closed #22307 ActiveModel::Dirty module documentation mistake.
- Closed #22357 config.assets.debug = true still compiles everything into single CSS/JS files?
- Closed #22356 Column spacing in schema.rb leads to superfluous line changes in diffs between versions
- Closed #22350 Hstore error: "TypeError: can't cast Hash to "
- Closed #22339 JS runtime not in Gemfile -> why ?
- Closed #22344 ConfirmationValidator doesn't fail if confirmation is absent
- Closed #22320 RouteProxy UrlHelpers became really slow in 4.2.5
- Closed #22329 Cannot call require from thread when I already required autoload.rb
- Closed #22337 Remove reference to scaffolding in Testing Guide
- Closed #22311 ActiveSupport::PerThreadRegistry - undefined method `delegate'
- Closed #22334 New shortcut: render_partial
17 Issues created by 16 people
- Opened #22413 ActiveJob perform_now and perform_later should accept the same arguments
- Opened #22412 db:structure:dump with MySQL includes current timestamp
- Opened #22408 If DuplicatePstatement will happen once, activerecord goes into DuplicatePstatement loop
- Opened #22407 has_one association works stand-alone but does not, when used in scope
- Opened #22405 collection_check_boxes does not produce the correct check box name property
- Opened #22404 SAVEPOINT not released on ROLLBACK in PostgreSQL
- Opened #22398 Datetime with precision value is logged without precision
- Opened #22396 Schema.rb generated incorrectly for columns with default of Infinity
- Opened #22392 counter_cache breaks relation extension (doc update?)
- Opened #22378 Running tests within an engine with pending migrations throws a wrong message
- Opened #22368 NoMethodError are reraised as ActionController::RoutingError and result in 404
- Opened #22364 Error installing development environment: Cannot exclude db group
- Opened #22360 Inflections - override translations
- Opened #22359 Support for DelayedJob reschedule_at and max_attempts
- Opened #22358 bad interaction with has_many, accepts_nested_attributes_for, and validates_presence_of
- Opened #22346 `rake db:dump` fails when `schema_search_path` is set
- Opened #22341 ActiveRecord::Associations::JoinDependency::JoinBase#name crashing with undefined local variable or method `reflection'
44 Unresolved conversations
Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.
- 16 new comments Open #22263 Add option to verify Origin header in CSRF checks
- 7 new comments Open #22205 consistent and efficient decement and increment behavior
- 7 new comments Open #17111 Better error message in case of miss use of a match instruction
- 7 new comments Open #16917 Methods for ActiveSupport::Duration parsing from ISO 8601 and output to it
- 6 new comments Open #16919 PostgreSQL interval datatype support
- 6 new comments Open #22313 disable rails minitest extension in rails plugin
- 4 new comments Open #21503 Use collection ids and timestamps to generate truly unique collection cache keys
- 3 new comments Open #20133 Do not use BASE58 for has_secure_token
- 3 new comments Open #22199 fix NoMethodError being raised when action is empty
- 3 new comments Open #22275 Per-form CSRF tokens
- 3 new comments Open #19439 Error in ActiveJob when logger defines method tagged, but logger formatter does not have method current_tags
- 2 new comments Open #22262 accepts_nested_attributes_for should accept allow_update option
- 2 new comments Open #22310 implement read_multi_entry to work alongside read_entry/write_entry
- 2 new comments Open #18496 Accept and default to base64url CSRF tokens.
- 2 new comments Open #21965 Rails Query throws Mysql2::Error: Unknown column randomly
- 2 new comments Open #17845 Don't leak Object constants in core_ext/module/qualified_const
- 1 new comment Open #22303 Remove meaningless `|| native_database_types[column.type][:limit]`
- 1 new comment Open #18155 Bugfix collection association #create method
- 1 new comment Open #17573 Response etags to always be weak: Prefixed 'W/' to value returned by Act...
- 1 new comment Open #20140 Out of range association ids throw exception before validation.
- 1 new comment Open #19440 Patch for issue #19439, ActiveJob::Logger should check that logger formatter responds to `current_tags`
- 1 new comment Open #22243 TimeZone offset can take DST into consideration
- 1 new comment Open #20168 Count results with custom `from` breaks
- 1 new comment Open #20420 Add options for rake routes task
- 1 new comment Open #22288 Implement rake proxy for rails cli
- 1 new comment Open #22281 Respect value of `:object` if `:object` is false when rendering
- 1 new comment Open #21254 Add Rails commands for existing rake tasks
- 1 new comment Open #22292 ROR 4.2.5 updated from 4.2.4: undefined method `attributes' for false:FalseClass
- 1 new comment Open #22250 No bind parameters used for Limit and Offset
- 1 new comment Open #22231 collection_radio_buttons doesn't work in Rails 5
- 1 new comment Open #22091 Log job arguments at debug level
- 1 new comment Open #21948 CSRF protection prevents some webkit users from submitting forms
- 1 new comment Open #21477 Rails.application.routes.recognize_path is not working for paths in engine
- 1 new comment Open #16959 Query with 'exists' subquery fails to bind parameters on 4.2.0.beta1, raises error on master
- 0 new comments Open #21688 Add short-hand methods for text and blob types in MySQL
- 0 new comments Open #21496 Add configurable serializers in each renderer
- 0 new comments Open #20701 Ensure input to distance_of_time_in_words is not nil
- 0 new comments Open #22283 [ci skip] add `controller:` argument to routing.md
- 0 new comments Open #20450 Guard against finder options or invalid-type column names in Relation#count
- 0 new comments Open #22291 Devide `PartialRenderer` into `CollectionRenderer` and `MemberR…
- 0 new comments Open #17904 hm:t association with order clause that references join table cannot be preloaded
- 0 new comments Open #17577 Strange scoping behaviour when `first_or_initialize` takes a block.
- 0 new comments Open #20005 Add `:expression` option support on the schema default