rails/rails

32 Pull requests merged by 20 people

• Merged #33743 add github to template actions, template actions minor refactor Aug 31, 2018
• Merged #33758 Faster permitted_scalar_filter Aug 31, 2018
• Merged #33766 Emit warning for unknown inflection rule when generating model. Aug 31, 2018
• Merged #33762 Typo in form_helpers.md guide Aug 30, 2018
• Merged #33751 Add hooks to ActiveJob around retries and discards Aug 30, 2018
• Merged #33637 Part 2: Multi-db improvements, Refactor Active Record configurations Aug 30, 2018
• Merged #33759 Do not recompute length Aug 30, 2018
• Merged #33760 Add migrations_paths option to migration generator Aug 30, 2018
• Merged #33761 [ci skip] Document permitted_scalar_filter Aug 30, 2018
• Merged #33757 Follow up #32937 [ci skip] Aug 30, 2018
• Merged #33755 Fix 5-1-stable build Aug 30, 2018
• Merged #33729 Find inverse associations with plural names Aug 29, 2018
• Merged #33752 20% faster `try` Aug 29, 2018
• Merged #33737 Add "Ruby on Rails 6.0 Release Notes" guide [ci skip] Aug 29, 2018
• Merged #33744 Prevent leaking of user's DB credentials on `rails db:create` failure Aug 29, 2018
• Merged #33749 Fewer allocations in caching/fragments.rb Aug 29, 2018
• Merged #33750 Faster time_value.rb Aug 29, 2018
• Merged #33747 32% Faster Object#try Aug 29, 2018
• Merged #33748 Drop load_database_yaml and fix test Aug 29, 2018
• Merged #33718 Finish converting whitelist and blacklist references Aug 29, 2018
• Merged #33683 Focus search input after page load on /rails/info/routes Aug 28, 2018
• Merged #33739 Use the HTTPS protocol for links to Edges Guides [ci skip] Aug 28, 2018
• Merged #33689 Mutation tracker should be cleared before continuing around callbacks Aug 28, 2018
• Merged #33721 Update the comments for TimeWithZone subtraction Aug 28, 2018
• Merged #33654 Fix numericality validator to still use value before type cast except Active Record Aug 28, 2018
• Merged #33735 Call block to #redirect_to in controller context Aug 28, 2018
• Merged #33733 Add documentation for `:collation` column option Aug 28, 2018
• Merged #31972 Update "Action View Form Helpers" guide Aug 27, 2018
• Merged #33727 Follow up #33523 [ci skip] Aug 27, 2018
• Merged #33723 Clarify example of the test [ci skip] Aug 25, 2018
• Merged #33661 Add test case to test enum in has_many Aug 25, 2018
• Merged #33722 Format respond_to method as code in doc [ci skip] Aug 25, 2018

6 Pull requests proposed by 6 people

• Proposed #33728 Add support to ActiveJob for locking jobs Aug 27, 2018
• Proposed #33756 Add `inspection_masks` to make values of sensitive database columns w… Aug 30, 2018
• Proposed #33763 WIP: failing test for eager loading Aug 30, 2018
• Proposed #33768 Attributes created by store_accessor can be casted with cast_type (#3… Aug 31, 2018
• Proposed #33769 ActiveSupport::Cache raises infinite loop when using Mongoid >= 6 Aug 31, 2018
• Proposed #33770 Part 3: Multi-db Improvements, identifying replica configurations Aug 31, 2018

23 Issues closed by 8 people

• Closed #33765 Rails 4.2: url_for() in a view raises ArgumentError in production but not development Aug 31, 2018
• Closed #32991 Missing documentation & alerts about major breaking changes in 5.2 ActiveRecord::AttributeMethods::Dirty (.attribute_changed?, .changes and .changed?) Aug 31, 2018
• Closed #33753 Dirty attribute changes for virtual attributes broken between Rails 5.0 and 5.2 Aug 30, 2018
• Closed #33764 ActiveRecord::StatementInvalid for async_exec Aug 30, 2018
• Closed #33746 ArgumentError running post method from ActionDispatch::IntegrationTest Aug 30, 2018
• Closed #32035 Possible regression of `after_rollback on: :update` and `after_rollback on: :destroy` is not working Aug 30, 2018
• Closed #33754 Would you accept a PR to override Integer#inspect? Aug 30, 2018
• Closed #27852 `db:create` Rake task leaks db credentials into logs Aug 29, 2018
• Closed #33745 action_dispatch/middleware/stack.rb: can't modify frozen Array Aug 29, 2018
• Closed #33742 Arrays are read incorrectly from Postgres when previously written to using index number Aug 29, 2018
• Closed #32909 Unhelpful Error Message after updating to Rails 5.2 Aug 29, 2018
• Closed #32953 Not-So-Intuitive behaviour of `optional: true` when using Inheritance Aug 29, 2018
• Closed #32962 The value of `previous_changes` in `after_commit` is strange when calling `touch` Aug 29, 2018
• Closed #33730 bizarre double transaction BEGIN, when expecting one. Aug 28, 2018
• Closed #33738 Eager loading for getting inheritance descendants (STI) fails under development as soon as code is refreshed. Aug 28, 2018
• Closed #33736 Arel serialize json , matches query error Aug 28, 2018
• Closed #33686 Changes to ActiveModel#numericality in 5.2.1 break ActiveAttr Aug 28, 2018
• Closed #33651 Numericality validation regression in 5.2.1 Aug 28, 2018
• Closed #33731 redirect_to does not execute proc in controller's context Aug 28, 2018
• Closed #33734 authenticate_with_http_token never yields Aug 27, 2018
• Closed #33702 "where" statement with large array - regression in 5.2 and master Aug 27, 2018
• Closed #33719 ActiveRecord: do not include order sql when running counts Aug 27, 2018
• Closed #33716 rails-ujs cleans up url line arguments from ajax get requests originated from a form Aug 26, 2018

3 Issues created by 3 people

• Opened #33767 Attributes created by store_accessor cannot be casted with cast_type Aug 31, 2018
• Opened #33741 Active Storage + validations Aug 28, 2018
• Opened #33732 Rails loads url_helper from engine module vs application module (if they have the same name) Aug 27, 2018

48 Unresolved conversations

Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.

• 9 new comments Open #33639 Make sure there are no duplicated nested records with create_with Aug 28, 2018
• 8 new comments Open #33549 Allow direct linking (no redirect) to files in ActiveStorage Aug 31, 2018
• 6 new comments Open #30787 Nested where query for customized-name associations Aug 26, 2018
• 5 new comments Open #16919 PostgreSQL interval datatype support Aug 29, 2018
• 4 new comments Open #32994 ActiveRecord::NoDatabaseError not raised Aug 27, 2018
• 4 new comments Open #20752 ActionView template finder can become really slow due to disk IO Aug 27, 2018
• 4 new comments Open #33669 Reduce memory bloat on new ActiveRecord connections (When DB has large number of tables) Aug 28, 2018
• 3 new comments Open #32346 Errno::ENAMETOOLONG on system test screenshot Aug 28, 2018
• 3 new comments Open #33075 Fix Collection cache key with limit and custom select Aug 30, 2018
• 3 new comments Open #33188 PostgreSQL: prepare for pg-1.1 Aug 31, 2018
• 2 new comments Open #33715 Precision value in Time with microsecond sometimes gets offset or inaccurate after AR is created Aug 25, 2018
• 2 new comments Open #32930 Duplicate form authenticity tokens when more than 1 form on the page Aug 27, 2018
• 2 new comments Open #32941 Execution of `actioncable/test/connection/stream_test.rb` raises the error in a thread. Aug 28, 2018
• 2 new comments Open #33031 Invoking column_defaults on a model causes inadvertent memoization of callable default attributes Aug 29, 2018
• 2 new comments Open #31419 ActiveStorage: Allow access to backing file from Service API Aug 30, 2018
• 2 new comments Open #14600 When all IPs are trusted, use the furthest away Aug 25, 2018
• 2 new comments Open #24945 sanitized_value should not remove cjk character Aug 31, 2018
• 2 new comments Open #33668 Ensure references creates id before type Aug 31, 2018
• 1 new comment Open #33002 Incorrect OR behavior in joins with merge Aug 27, 2018
• 1 new comment Open #33056 ActiveRecord collection cache key with limit and custom select (PG:AmbigousColumn: Error) Aug 27, 2018
• 1 new comment Open #29693 Deadlock between ParamsWrapper#model and Loadable#require_or_load Aug 28, 2018
• 1 new comment Open #33705 wrong number of arguments (given 2, expected 0): home page(localhost:3000) Aug 28, 2018
• 1 new comment Open #33630 Aws::S3::Errors::InvalidRange exception while saving ActiveStorage model with attached 0-byte length file Aug 30, 2018
• 1 new comment Open #33160 Active Storage - Disk Service always return http URL even when https is used. Aug 30, 2018
• 1 new comment Open #31445 ActiveRecord 5.1 - #includes raises NoMethodError when case doesn't match on join columns Aug 30, 2018
• 1 new comment Open #33045 Tagged Logging memory leak due to uncleared thread local storage Aug 31, 2018
• 1 new comment Open #32821 `render` and `yield` output wrong markup when using xml builder with `cache` Aug 31, 2018
• 1 new comment Open #33021 Active Storage with config.reload_classes_only_on_change slows the image loading quite a lot Aug 31, 2018
• 1 new comment Open #32700 lot of 'is already being watched through' messages when using rails console if using node_modules Aug 31, 2018
• 1 new comment Open #30047 ActiveSupport::PerThreadRegistry is pre Fiber and not PerThread. Aug 31, 2018
• 1 new comment Open #21235 Make dbconsole default to using database.yml password. Aug 27, 2018
• 1 new comment Open #26911 ActiveSupport::TimeZone#tzinfo cannot be nil anymore Aug 29, 2018
• 1 new comment Open #28209 [Railties] Add config rake_eager_load Aug 29, 2018
• 1 new comment Open #31752 Fix `includes` unable to handle joins on case insensitive columns Aug 30, 2018
• 1 new comment Open #33295 ActiveCable support for rack/rack PR #1272 Aug 25, 2018
• 1 new comment Open #33527 Added AR associations lazy preloading Aug 29, 2018
• 1 new comment Open #33673 Fix regression setting children record in parent before_save callback. Sep 1, 2018
• 1 new comment Open #33717 Fixed the QueryMethod unscope issue for nested attributes Aug 25, 2018
• 0 new comments Open #33428 Enum column not working as expected in where clause when join with custom named association Aug 25, 2018
• 0 new comments Open #33720 ActiveStorage direct uploads ActiveRecord::RecordNotUnique Aug 25, 2018
• 0 new comments Open #19388 Avoid violating key constraints in fixture HABTM associations Aug 27, 2018
• 0 new comments Open #24207 Allow grouping by Arel::Nodes::NamedFunction Aug 27, 2018
• 0 new comments Open #25069 Issue #24796 -- enumerable#sum edge case Aug 31, 2018
• 0 new comments Open #27792 TaggedLogging to return a new logger instance Aug 29, 2018
• 0 new comments Open #32971 Enable `Performance/UnfreezeString` cop Aug 31, 2018
• 0 new comments Open #33589 Fix issue with cached partial collections Aug 28, 2018
• 0 new comments Open #33608 Use utf8mb4 character set by default for MySQL database Aug 31, 2018
• 0 new comments Open #33640 Add webpacker without making the build hang/timeout. Aug 29, 2018