Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Output is compressed multiple times #101

Closed
nex3 opened this Issue · 2 comments

3 participants

@nex3
Collaborator

Currently it's possible for a Sass file, generated in compressed mode, to be re-compressed by Sass. There's a heuristic to avoid that, but it's pretty shaky; if there are any multiline /*! */ comments, re-compression is triggered. Not only is this inefficient, it could potentially cause unexpected and confusing bugs if the generated CSS is something that Sass can't understand as input.

It seems like there should be a more principled way for CssCompressor to avoid conflicting with Sass's compressed mode.

@chriseppstein
Collaborator

@nex3 That would be a sprocket's issue. They would need to provide a way for a file to be compressed at the same time as it is processed and then to be marked as such. Sass rails must work within the constraints sprockets enforces. I've added the heuristic to speed up the majority of use cases, but I think this bug will need sister bugs in both rails and sprockets in order to achieve this.

cc: @josh @sstephenson @guilleiguaran @wycats

@frodsan

Closing here because there's been no response in months. @nex3 I'll re-open it if it's still present.

@frodsan frodsan closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.