Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Sass End-of-Life: 26 March 2019 #420

Closed
chriseppstein opened this issue May 15, 2018 · 14 comments

Comments

@chriseppstein
Copy link
Collaborator

@chriseppstein chriseppstein commented May 15, 2018

This was announced about a month ago, but I wanted to make sure the Rails community is aware that the Ruby implementation of Sass has been EOL'd.

TL;DR:

  • The reference implementation of Sass is now written in Dart.
  • Ruby Sass is maintained for security and CSS Compatibility issues through March 2019.
  • Only PRs for the above mentioned reasons are being accepted at this time.
  • The git repo for ruby sass is now officially at https://github.com/sass/ruby-sass
  • The repo at https://github.com/sass/sass is now for implementation-agnostic language issues.
  • On 26 March 2019, the deprecation period for Ruby Sass will end and it will no longer be maintained.

That is, unless, there's at least one new, active maintainer for the ruby implementation of Sass. Preferably more than one.

Rails needs a plan a plan to deal with this before the ruby version becomes unmaintained. If a first-class Sass implementation for the ruby and rails community is desired, hopefully a maintainer can be found. Otherwise, one of the other Sass implementations can be used (most likely through node/npm).

@EugenMayer

This comment has been minimized.

Copy link

@EugenMayer EugenMayer commented Aug 3, 2018

any progress here?

nickcharlton added a commit to thoughtbot/administrate that referenced this issue Aug 6, 2018
Ruby Sass will reach end of life on 26th Match 2019. This switches to
`sassc-rails` and drops the appraisal for Sass 3.4.

Currently, `sassc-rails` still has `sass` as a dependency hence this is still
included in the `Gemfile.lock`.

See: rails/sass-rails#420

Fixes #1196.
@NARKOZ

This comment has been minimized.

Copy link

@NARKOZ NARKOZ commented Aug 8, 2018

SassC requires CRuby

nickcharlton added a commit to thoughtbot/administrate that referenced this issue Aug 10, 2018
Ruby Sass will reach end of life on 26th Match 2019. This switches to
`sassc-rails` and drops the appraisal for Sass 3.4.

Currently, `sassc-rails` still has `sass` as a dependency hence this is still
included in the `Gemfile.lock`.

See: rails/sass-rails#420

Fixes #1196.
@jrochkind

This comment has been minimized.

Copy link

@jrochkind jrochkind commented Oct 15, 2018

Generating a new default Rails 5.2 app gets you this deprecation warning.

March 2019 is coming up, is there any news on what is expected?

@coorasse

This comment has been minimized.

Copy link

@coorasse coorasse commented Oct 27, 2018

I personally started switching to Webpacker.
Migration of existing apps it is pretty easy and it will be the default Javascript compiler in Rails 6.
Migrating CSS is even easier than migrating JS. I leave here a guide to do that.
I hope it will help someone else.

@Fudoshiki

This comment has been minimized.

Copy link
Contributor

@Fudoshiki Fudoshiki commented Nov 26, 2018

@coorasse I need simple css file for each page, not bundle, Sprockets do that easy, with Webpack this is no trivial task
Not for all sites need react and not all sites are SPA

pjaspers added a commit to BLSQ/orbf2 that referenced this issue Dec 10, 2018
For CRuby, this is a fix for: rails/sass-rails#420

Long story short, ruby sass is unsupported as of March 2019, this
switches to libsass, which is supported.
pjaspers added a commit to BLSQ/orbf2 that referenced this issue Dec 12, 2018
For CRuby, this is a fix for: rails/sass-rails#420

Long story short, ruby sass is unsupported as of March 2019, this
switches to libsass, which is supported.
@amalrik

This comment has been minimized.

Copy link

@amalrik amalrik commented Dec 19, 2018

Maybe sassc-rails should be used as a drop-in replacement for sass-rails? I have the impression it should be pretty easy to change that on rails generators.

@amalrik

This comment has been minimized.

Copy link

@amalrik amalrik commented Dec 19, 2018

Ok
now I see the thread on rails main repo and it seems its not possible to simple replace sass-rails with sassc-rails. So migrate to webpacker seems to be the way to go.

@jrochkind

This comment has been minimized.

Copy link

@jrochkind jrochkind commented Dec 19, 2018

@amalrik can you link to the thread on rails main repo for us?

In my specific apps, I have switched to sassc-rails without problem. Although I have no trouble believing there are reasons it can't work universally. I am curious to see what is being discussed on rails repo.

@amalrik

This comment has been minimized.

Copy link

@amalrik amalrik commented Dec 19, 2018

@jakeonfire

This comment has been minimized.

Copy link

@jakeonfire jakeonfire commented Jan 26, 2019

@amalrik the tables have turned again in favor of sassc-rails: #420
[edit: or at least there is still debate and desire to avoid forcing everyone to use Webpacker]

@P9GIT

This comment has been minimized.

Copy link

@P9GIT P9GIT commented Jan 30, 2019

@amalrik

They are still contemplating simply replacing the sass processor with the sassc processor in sass-rails it seems: rails/rails#34884 (comment)

@amalrik

This comment has been minimized.

Copy link

@amalrik amalrik commented Jan 30, 2019

thanks @P9GIT
I will take a look if I can contribute to that in some way.

@guilleiguaran

This comment has been minimized.

Copy link
Member

@guilleiguaran guilleiguaran commented Mar 16, 2019

See #424

@P9GIT

This comment has been minimized.

Copy link

@P9GIT P9GIT commented Mar 18, 2019

@guilleiguaran

Awesome! Thanks!

nickcharlton added a commit to thoughtbot/administrate that referenced this issue Apr 19, 2019
Ruby Sass will reach end of life on 26th Match 2019. This switches to
`sassc-rails` and drops the appraisal for Sass 3.4.

Currently, `sassc-rails` still has `sass` as a dependency hence this is still
included in the `Gemfile.lock`.

See: rails/sass-rails#420

Fixes #1196.
nickcharlton added a commit to thoughtbot/administrate that referenced this issue Apr 19, 2019
Ruby Sass will reach end of life on 26th Match 2019. This switches to
`sassc-rails` and drops the appraisal for Sass 3.4.

Currently, `sassc-rails` still has `sass` as a dependency hence this is still
included in the `Gemfile.lock`.

See: rails/sass-rails#420

Fixes #1196.
jlblcc added a commit to adiwg/mdTranslator-rails that referenced this issue May 17, 2019
sass-rails is deprecated, see
rails/sass-rails#420
bilbof added a commit to alphagov/finder-frontend that referenced this issue Jun 12, 2019
This gem has been deprecated and the recommended
replacement is the sassc-rails gem.

Its a drop in replacement so we dont need to do
anything else.

For context see rails/sass-rails#420.

It seems v6 of the gem we are using will make it
a wrapper for the other gem. We can upgrade already
so theres no need to wait for this.

Trello: https://trello.com/c/hcmzrcot/772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.