Skip to content
This repository

Rails 3.1 compatible branch doesn't work w/o Asset Pipeline #84

Closed
wants to merge 3 commits into from

5 participants

Urban Hafner Francesco Rodríguez Matt Boehlig José Valim

Please fix the Rails 3.1 compatible branch and release a version 3.1.6.

Thanks!

CHANGELOG.md
... ...
@@ -1,6 +1,10 @@
1 1
 CHANGELOG
2 2
 =========
3 3
 
  4
+3.1.6 (Dec 24, 2011)
  5
+---------------------
  6
+* Fixing #64 (incompatibility with deactivated Asset Piepeline)
1

typo in Pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Urban Hafner
ujh commented March 09, 2012

It's also possible to fake the asset pipeline for the benefit of sass-rails: http://bettong.net/2012/03/07/using-sass-rails-3-dot-1-5-without-the-asset-pipeline-on-rails-3-dot-1-4/

Qingfeng Frank Duan fduan referenced this pull request from a commit in fduan/sass-rails September 13, 2012
make sass-rails work for rails 3.1 app without asset pipeline enabled…
… - applied the fixes for issues #81 and #84
de76a03
Qingfeng Frank Duan fduan referenced this pull request from a commit in fduan/sass-rails September 13, 2012
make sass-rails work for rails 3.1 app without asset pipeline enabled…
… - applied the fixes for issues #81 and #84 - fixed typo
d00cb68
Francesco Rodríguez

This PR is no longer valid 636f668 /cc @rafaelfranca

Francesco Rodríguez frodsan closed this April 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 3 unique commits by 2 authors.

Dec 23, 2011
José Valim Check if app.assets is set before using it.
(cherry picked from commit 636f668)
c676dbb
updating version number 8bb1946
Jan 16, 2012
fixing typo ad63673
This page is out of date. Refresh to see the latest.
4  CHANGELOG.md
Source Rendered
... ...
@@ -1,6 +1,10 @@
1 1
 CHANGELOG
2 2
 =========
3 3
 
  4
+3.1.6 (Dec 24, 2011)
  5
+---------------------
  6
+* Fixing #64 (incompatibility with deactivated Asset Pipeline)
  7
+
4 8
 3.1.5.rc.1 (Oct 16, 2011)
5 9
 ---------------------
6 10
 * Several bug fixes
7  lib/sass/rails/railtie.rb
@@ -58,8 +58,11 @@ module SassContext
58 58
         # Display a stack trace in the css output when in development-like environments.
59 59
         config.sass.full_exception = app.config.consider_all_requests_local
60 60
       end
61  
-      app.assets.context_class.extend(SassContext)
62  
-      app.assets.context_class.sass_config = app.config.sass
  61
+
  62
+      if app.assets
  63
+        app.assets.context_class.extend(SassContext)
  64
+        app.assets.context_class.sass_config = app.config.sass
  65
+      end
63 66
 
64 67
       Sass.logger = app.config.sass.logger
65 68
     end
2  lib/sass/rails/version.rb
... ...
@@ -1,5 +1,5 @@
1 1
 module Sass
2 2
   module Rails
3  
-    VERSION = "3.1.5"
  3
+    VERSION = "3.1.6"
4 4
   end
5 5
 end
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.