Skip to content

Conversation

@strzibny
Copy link
Contributor

@strzibny strzibny commented Nov 6, 2013

sdoc --version should return the version of sdoc and not version of rdoc.

@strzibny strzibny mentioned this pull request Nov 6, 2013
@zzak
Copy link
Member

zzak commented Dec 20, 2013

I'd like to get this merged, but it's an unrelated feature, so it will have to wait until we can bump rdoc and do a release.

Thank you!

@zzak
Copy link
Member

zzak commented Dec 20, 2013

Also, I think we should do something like if ARGV.include?("--version")

@zzak
Copy link
Member

zzak commented Dec 27, 2013

Could you rebase this? Thanks!

@strzibny
Copy link
Contributor Author

@zzak I will.

@strzibny
Copy link
Contributor Author

Edited and rebased. You can cherry-pick if you wish.

@zzak
Copy link
Member

zzak commented Dec 29, 2013

I will accept a patch for lib/sdoc.rb and sdoc.gemspec, but I cannot accept the bin patch without a test (and even then I think we will wait until the next patch level version).

If you could send me a patch for just that I will gladly merge it before doing the release of 0.4.0.

Thanks!

@zzak
Copy link
Member

zzak commented Dec 29, 2013

Sorry to be so picky, I have limited time for SDoc at the moment.

@zzak
Copy link
Member

zzak commented Jan 1, 2014

@strzibny Thanks I've applied parts of your commit to lib/sdoc.rb and cherry-picked the sdoc.gemspec change.

Please send a separate patch for the --version option and we can discuss it after the 0.4.0 release

@zzak zzak closed this Jan 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants