From 84f90effb257b85124c1fcb86060037d83dee653 Mon Sep 17 00:00:00 2001 From: Simon Claessens Date: Wed, 20 Dec 2023 12:45:16 +0100 Subject: [PATCH 1/2] fix empty binds put the right default binds value as in https://github.com/rails/rails/blob/bf725a787609cf24ae64d763636513fc0bfdd4bf/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb#L100 --- app/models/solid_cache/entry.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/solid_cache/entry.rb b/app/models/solid_cache/entry.rb index 11686d8..7717cb9 100644 --- a/app/models/solid_cache/entry.rb +++ b/app/models/solid_cache/entry.rb @@ -113,7 +113,7 @@ def select_all_no_query_cache(query, values) if connection.prepared_statements? result = connection.select_all(sanitize_sql(query), "#{name} Load", Array(values), preparable: true) else - result = connection.select_all(sanitize_sql([ query, values ]), "#{name} Load", nil, preparable: false) + result = connection.select_all(sanitize_sql([ query, values ]), "#{name} Load", [], preparable: false) end result.cast_values(SolidCache::Entry.attribute_types) From 87464482f4ae245b3cffd29c833ad670940c072a Mon Sep 17 00:00:00 2001 From: Simon Claessens Date: Wed, 20 Dec 2023 13:22:43 +0100 Subject: [PATCH 2/2] provide values into binds --- app/models/solid_cache/entry.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/solid_cache/entry.rb b/app/models/solid_cache/entry.rb index 7717cb9..feaa9f4 100644 --- a/app/models/solid_cache/entry.rb +++ b/app/models/solid_cache/entry.rb @@ -113,7 +113,7 @@ def select_all_no_query_cache(query, values) if connection.prepared_statements? result = connection.select_all(sanitize_sql(query), "#{name} Load", Array(values), preparable: true) else - result = connection.select_all(sanitize_sql([ query, values ]), "#{name} Load", [], preparable: false) + result = connection.select_all(sanitize_sql([ query, values ]), "#{name} Load", Array(values), preparable: false) end result.cast_values(SolidCache::Entry.attribute_types)