Conversation
Supporting concurrency-limited, scheduled and immediate jobs.
It's not really necessary, and will allow for some DRY. Just let Rails set it.
From now, used only when moving scheduled executions to ready executions. Also, change `assume_attributes_from_job` to `assumes_attributes_from_job`, 3rd person singular, to be consistent with other similar methods.
Taking advantage of the new methods created in previous commits.
This allows even further DRYing and simplification, as we can unify the dispatching done when moving a scheduled job batch to ready, having to deal with concurrency-limited jobs, and the same thing when enqueuing multiple jobs.
Only for those enqueued successfully, that's it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was introduced in Active Job in rails/rails#46603.
It wasn't properly supported until now in Solid Queue, as the adapter didn't respond to
#enqueue_all, which means all jobs passed over toperform_all_laterwere enqueued one by one. With this pull request, we add proper support, minimizing the number of queries we have to perform. We still need to enqueue concurrency-limited jobs one by one, just like when moving them fromscheduledtoready, but for scheduled jobs and ready-to-be-run jobs, we can insert these viainsert_all.With this implementation, everything is run within the same transaction and right now, there's no batching. All jobs passed to
enqueue_allare inserted at once. This will be problematic if the batch is very large, causing problems with locking and with replica lag. However, this matches the behaviour of other adapters, leaving the batching up to the user ofperform_all_later.