Permalink
Commits on Dec 12, 2017
  1. Merge pull request #414 from rails/schneems/more-error-stuff

    rafaelfranca committed Dec 12, 2017
    Schneems/more error stuff
Commits on Nov 17, 2017
  1. Extra newline in exception

    schneems committed Nov 17, 2017
    ```
    Sprockets::Rails::Helper::AssetNotPrecompiled: Asset `application.scss` was not declared to be precompiled in production.
    Declare links to your assets in `app/assets/config/manifest.js`.
    
      //= link application.scss
    and restart your server
    ```
    
    Becomes
    
    ```
    Sprockets::Rails::Helper::AssetNotPrecompiled: Asset `application.scss` was not declared to be precompiled in production.
    Declare links to your assets in `app/assets/config/manifest.js`.
    
      //= link application.scss
    
    and restart your server
    ```
  2. Use word “error” in error class.

    schneems committed Nov 17, 2017
    Subclassed from original error incase anyone was rescuing it.
Commits on Sep 6, 2017
  1. Always use newest bundler in the CI

    amatsuda committed Sep 6, 2017
    This fixes "NoMethodError: undefined method `spec' for nil:NilClass" on 1.9.3
    and similar errors in the future
Commits on Aug 31, 2017
  1. Remove CHANGELOG

    rafaelfranca committed Aug 31, 2017
    We are using GitHub releases page
  2. Prepare to 3.2.1 release

    rafaelfranca committed Aug 31, 2017
Commits on Aug 15, 2017
  1. Merge pull request #409 from junaruga/hotfix/undefined-metohd-split-f…

    rafaelfranca committed Aug 15, 2017
    …or-nil-class
    
    Fix a test failure for undefined method `split' for nil:NilClass.
Commits on May 30, 2017
  1. Merge pull request #404 from junaruga/feature/readme-badge-master

    schneems committed May 30, 2017
    Specify master branch for Travis build status image.
Commits on May 29, 2017
Commits on Mar 14, 2017
  1. Fix tests

    schneems committed Mar 13, 2017
    Tests were broken when the default paths that rails loads started to include an asset in action_view. Instead of testing for such brittle conditions, we can look for the elements we want instead.
Commits on Nov 9, 2016
  1. Merge pull request #383 from EiNSTeiN-/patch-1

    rafaelfranca committed Nov 9, 2016
    Be more specific with required file
  2. Be more specific with required file

    EiNSTeiN- committed Nov 9, 2016
    This fixes a problem with being unable to load `ActionView::Helpers::AssetUrlHelper` from L7 in some situations
Commits on Sep 26, 2016
  1. Merge pull request #380 from dreyks/patch-1

    schneems committed Sep 26, 2016
    fix changelog entry about unknown_asset_fallback
Commits on Sep 1, 2016
  1. [ci skip] v3.2.0

    schneems committed Sep 1, 2016
  2. Merge pull request #375 from rails/schneems/deprecate-fallback-behavior

    schneems committed Sep 1, 2016
    Deprecate asset fallback
Commits on Aug 31, 2016
  1. Remove "you" from deprecation.

    schneems committed Aug 31, 2016
  2. Remove unused method

    schneems committed Aug 31, 2016
  3. Better copy and deprecation message

    schneems committed Aug 31, 2016
    Address comments by @kaspth
Commits on Aug 30, 2016
  1. Change option name to `skip_pipeline`

    schneems committed Aug 30, 2016
Commits on Aug 29, 2016
  1. Merge pull request #377 from ivanovaleksey/fix-code-style

    schneems committed Aug 29, 2016
    fix some code style
  2. fix some code style

    ivanovaleksey committed Aug 29, 2016
Commits on Aug 23, 2016
  1. public_* API is not desired

    schneems committed Aug 23, 2016
    - Use `public_folder: true` instead.
    - Allow configurable deprecation/error behavior via **`config.assets.unknown_asset_fallback`**
    
    When set to a truthy value, the a result will be returned even if the requested asset is not found in the asset pipeline. When set to `false` it will raise an error.
Commits on Aug 22, 2016
  1. public_* API is not desired

    schneems committed Aug 22, 2016
    Use `public_folder: true` instead.
Commits on Aug 20, 2016
  1. Better way to find deprecated method location

    schneems committed Aug 20, 2016
    Instead of relying on hard coded indexes, we can look through the called method stack backwards (i.e. the first method called will be the first in the list). If it has a suffix for one of our APIs, then we check to see if there exists a `public_` prefix on the view, if it does it's the first method called that can be deprecated so we point to that.
Commits on Aug 19, 2016
  1. Deprecate asset fallback

    schneems committed Aug 19, 2016
    When an asset isn't found the behavior is to pass the string through. For example a valid asset will return a url from pipeline
    
    ```
    asset_path("application.js")
    # => assets/application-123098udasvi0mnafd.js
    ```
    
    While if you make a typo, you won't get an error or anything, it just falls through:
    
    ```
    asset_path("app1icati0n.js")
    # => "app1icati0n.js"
    ```
    
    Hopefully I don't have to elaborate on why this is bad.
    
    This PR is a child PR to one in Rails that will introduce a `public_asset_path` API.
    
    There are valid reasons for not using the asset pipeline, if you have a purely static asset in the public folder or if you want to link to a static URL in your assets somewhere it makes sense to declare that intention. Eventually we will replace the behavior of the deprecation with an exception so people don't lose hours of their to typos.
    
    We only emit the deprecation when a `public_` api is available in Rails. This means that sprockets-rails can still be used in a backwards compatible manner.
Commits on Jun 29, 2016
  1. Release 3.1.1

    rafaelfranca committed Jun 29, 2016