Silence asset requests with config.assets.quiet #355

Merged
merged 1 commit into from Jun 9, 2016

Projects

None yet

4 participants

@kmcphillips
Contributor

@rafaelfranca @josh

Builds on and finishes what @route started in #338.

Basically a deprecation of the quiet_assets gem.

Adds the config.assets.quiet option. Defaulted to false in all cases. When true, it loads a middleware. That middleware looks at the asset prefix path, and if matches will wrap the given request in a logger.silence { } call.

I've added to the README but I don't know if/where I should document it further.

@rails-bot

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca
Member

Looks great. It seems the sprockets 4 tests are not passing. I guess it is because the tests you defined needs to point to a manifest file. Could you take a look?

@kmcphillips
Contributor

Build fixed. 💚

@rafaelfranca rafaelfranca merged commit 7fa2b4d into rails:master Jun 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sonalkr132

Can we have version release please 💙

@randx randx pushed a commit to gitlabhq/gitlabhq that referenced this pull request Jul 4, 2016
@connorshea connorshea Remove quiet_assets in favor of built-in sprockets-rails config.
quiet_assets has been seemingly abandoned, and now sprockets-rails has the feature built-in!

From this PR: rails/sprockets-rails#355
eb70f05
@randx randx pushed a commit to gitlabhq/gitlabhq that referenced this pull request Jul 4, 2016
@tsigo tsigo Merge branch 'upgrade-sprockets-rails' into 'master'
Upgrade sprockets and sprockets rails, remove quiet_assets

## What does this MR do?

Upgrade Sprockets from 3.6.0 to 3.6.2.

Changelog: https://github.com/rails/sprockets/blob/3.x/CHANGELOG.md

Upgrade Sprockets Rails from 3.0.4 to 3.1.1.

Changelog: rails/sprockets-rails@v3.0.4...v3.1.1

quiet_assets has been seemingly abandoned, and now sprockets-rails has the feature built-in!

The config was added in this PR: rails/sprockets-rails#355

Working towards #14286.

See merge request !5029
b37a8d8
@gabebw gabebw added a commit to gabebw/hotline-webring that referenced this pull request Jul 8, 2016
@gabebw gabebw Use Rails 5.0.0
We were using Rails 5.0.0.rc1.

* Instead of the `quiet_assets` gem, set `config.assets.quiet = true`: rails/sprockets-rails#355
* Remove `coffee-rails`, which wasn't being used
4d723a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment