Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.7 deprecation in helper.rb #454

Merged
merged 1 commit into from Dec 27, 2019

Conversation

@connorshea
Copy link
Contributor

connorshea commented Dec 27, 2019

This is a sibling PR to rails/sprockets#660. This needs to be changed to fix sprockets-rails causing a deprecation warning after the sprockets deprecation warning is fixed.

I've tested this on my Rails app and my test suite passes just fine with this change even if the sprockets change isn't present.

Oddly, this may actually be the only change that's necessary. I don't see any deprecation warning anymore with just this PR, regardless of whether the sprockets change is made or not.

@rafaelfranca rafaelfranca merged commit b0b380e into rails:master Dec 27, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@connorshea connorshea deleted the connorshea:fix-ruby-27-deprecations branch Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.