New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset-data-url SVG encoding: use URL escaping #520

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
4 participants
@glebm
Contributor

glebm commented Nov 18, 2017

Use URL escaping instead of base64 for encoding data-URI SVGs in order to reduce size.

Test case demo: https://codepen.io/glebm/pen/yPpaRr
Resolves #425

@schneems

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Nov 18, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot commented Nov 18, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

asset-data-url SVG encoding: use URL escaping
Use URL escaping instead of base64 for encoding data-URI SVGs in order
to reduce size.

Test case demo: https://codepen.io/glebm/pen/yPpaRr
Resolves #425
@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems Nov 20, 2017

Member

Thanks!

Member

schneems commented Nov 20, 2017

Thanks!

@schneems schneems merged commit accf18d into rails:master Nov 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment