Stop fetch from mutating when default is a hash #102

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

bemurphy commented Feb 19, 2013

See gh-56 for an issue on this

This line makes me uneasy. It's needed for the "sticky" tests to pass but I feel like the Parameters were permitted then we dropped new data via a default hash, which hasn't been checked. Maybe that's OK because you are in control since they are defaults?

phene commented Jul 5, 2013

Huge +1 This has been a really annoying bug.

phene commented Jul 5, 2013

@bemurphy Could you get the tests passing again?

Owner

rafaelfranca commented Jul 5, 2013

First, we need to fix this issue on rails/rails, after this we can merge it on the gem.

I resubmitted this to rails, it's merged here: rails/rails#12656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment