This repository has been archived by the owner. It is now read-only.

Rails 3.0+ Compatibility #13

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

I went ahead and isolated the issues that were causing failures using strong_parameters with rails 3.0 stable. I'm not entirely sold on my proposed solution, but figured I'd get the conversation started on the best way to achieve 3.0+ compatibility :)

Owner

dhh commented Mar 29, 2012

We just got another solution merged for the dup. Can you update and see if that fixes the problem? Otherwise I'm glad to see this become 3.0 compatible.

I tested with the recently merged dup solution (#12), but the test was still failing in rails 3-0 stable due to 3.0's HashWithIndifferentAccess#dup not using self.class.new: https://github.com/rails/rails/blob/3-0-stable/activesupport/lib/active_support/hash_with_indifferent_access.rb#L99-101

I went ahead and merged the recent dup solution with the 3.0 fix and updated the commit. Tests are now fully passing in 3.0 and 3.2. Let me know if that works!

A new test failure has also arisen from the use of module_namespacing (introduced in Rails 3.1) in the controller scaffold template:

Finished tests in 0.263376s, 98.7182 tests/s, 212.6238 assertions/s.

  1) Error:
test_controller_content(StrongParametersControllerGeneratorTest):
NoMethodError: undefined method `module_namespacing' for #<Rails::Generators::StrongParametersControllerGenerator:0x007fcbb4dde190>
    (erb):1:in `template'

26 tests, 56 assertions, 0 failures, 1 errors, 0 skips

The current fixes in this pull request would make strong_parameters compatible with Rails 3.1, but fixing this failure for 3.0 would be hacky.

Owner

dhh commented Oct 4, 2012

I'd be happy with 3.1 compatibility, then. Can we update this PR to get that done?

Contributor

orend commented Oct 17, 2012

This PR doesn't work with the current code base - rails 3.0 or 3.1. I've opened a new pull request for adding rails 3.1 compatibility here: #46.

Owner

rafaelfranca commented Oct 17, 2012

Closing this in favor of #46

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.