Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuetify requires Dart `sass` instead of `node-sass` #2239

Open
dfabreguette-ap opened this issue Aug 19, 2019 · 5 comments

Comments

@dfabreguette-ap
Copy link

@dfabreguette-ap dfabreguette-ap commented Aug 19, 2019

Hey !
I'm having this issue installing vuetify on a rails app.
https://vuetifyjs.com/en/getting-started/frequently-asked-questions#invalid-css-after-content-expected-was-material-light
Looking at my yarn.lock file, I realised node_sass was a Rails Webpacker dependency.
Any chance someone had same issue and knows how to either remove node_sass dependency OR force wepack to use sass lib ?

@jakeNiemiec

This comment has been minimized.

Copy link
Member

@jakeNiemiec jakeNiemiec commented Aug 19, 2019

Webpacker does not support the Dart sass package. One of the comments in this issue may help: #2235 (comment)

@gkatsanos

This comment has been minimized.

Copy link

@gkatsanos gkatsanos commented Aug 26, 2019

Webpacker should make an effort to be more agnostic for things like loaders etc and accept everything from an external config value or parameter. It's a continuous fight to override it's baked-in configuration. I understand it's built for a particular audience but at least let's document the possibility to delete the existing configuration :)

PS: it appears node-sass is not actively maintained and dart-sass is a better solution.

@jakeNiemiec

This comment has been minimized.

Copy link
Member

@jakeNiemiec jakeNiemiec commented Aug 26, 2019

it appears node-sass is not actively maintained and dart-sass is a better solution.

What leads you to say that? I could not find anything to that effect:

@gkatsanos

This comment has been minimized.

Copy link

@gkatsanos gkatsanos commented Aug 26, 2019

I stand corrected. It's slowly losing momentum. Node sass always had issues, its big bulky and has dependencies. There's also the infamous rebuild flag needed when you change OS. For more info, :

JeffreyWay/laravel-mix#1832

@jakeNiemiec

This comment has been minimized.

Copy link
Member

@jakeNiemiec jakeNiemiec commented Aug 26, 2019

image

It's slowly losing momentum.

Agreed, but very slowly. 🐢

I would rather have a quicker solution at the cost of standard maintenance. Node Sass is just a wrapper around LibSass, the native C++ implementation of Sass. This is why it needs to be built specifically to your OS.

Dart Sass, is reportedly up to 3x slower since you're computing things from within a VM: sass/dart-sass#113

@jakeNiemiec jakeNiemiec added help wanted and removed support labels Aug 26, 2019
@jakeNiemiec jakeNiemiec changed the title Vuetify / sass instead of node_sass Vuetify requires Dart `sass` instead of `node-sass` Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.