Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpacker:compile exit on failure #728

Merged
merged 1 commit into from Aug 31, 2017
Merged

Fix webpacker:compile exit on failure #728

merged 1 commit into from Aug 31, 2017

Conversation

@javan
Copy link
Member

@javan javan commented Aug 31, 2017

Webpacker.compile would always return manifest.refresh even if compiler.compile failed. This means deploys would succeed even if compiling failed.

`Webpacker.compile` would always return `manifest.refresh` even if `compiler.compile` failed
@javan javan merged commit b7e69e9 into master Aug 31, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@javan javan deleted the fix-compile-failure-exit branch Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.