Skip to content
Find file
Fetching contributors…
Cannot retrieve contributors at this time
275 lines (274 sloc) 11.9 KB
{
"errors":[
{
"type": "RailsBestPractices::Reviews::AlwaysAddDbIndexReview",
"short_filename": "db/schema.rb",
"line_number": "125",
"message": "always add db index (jobs => [external_id])",
"url": "http://rails-bestpractices.com/posts/21-always-add-db-index",
"git_commit": "bdee07ec",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseBeforeFilterReview",
"short_filename": "app/cells/sidebar_cell.rb",
"line_number": "36,50,54",
"message": "use before_filter for login,posts_navigation,blog_rss",
"url": "http://rails-bestpractices.com/posts/22-use-before_filter",
"git_commit": "e053479c",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseBeforeFilterReview",
"short_filename": "app/cells/vote_cell.rb",
"line_number": "18,24,33",
"message": "use before_filter for show,up,down",
"url": "http://rails-bestpractices.com/posts/22-use-before_filter",
"git_commit": "72606729",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::MoveCodeIntoModelReview",
"short_filename": "app/views/kaminari/_paginator.html.haml",
"line_number": "13",
"message": "move code into model (page use_count > 2)",
"url": "http://rails-bestpractices.com/posts/25-move-code-into-model",
"git_commit": "d08855f4",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20100726144246_add_implemented_to_posts.rb",
"line_number": "5",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "4b3979be",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20100727124152_add_counter_cache_to_users.rb",
"line_number": "8",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "bc72f0e0",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20100801071356_change_votes_to_polymorphic.rb",
"line_number": "6",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "930cc087",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20100807150111_remove_comments_from_implementations.rb",
"line_number": "4",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "b2e34578",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110511145447_create_post_bodies.rb",
"line_number": "10",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "ac7d25e8",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110511145447_create_post_bodies.rb",
"line_number": "18",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "ac7d25e8",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110620144449_create_answer_bodies.rb",
"line_number": "10",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "1a232dd1",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110620144449_create_answer_bodies.rb",
"line_number": "18",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "1a232dd1",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110627151243_create_question_bodies.rb",
"line_number": "10",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "c3972a37",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110627151243_create_question_bodies.rb",
"line_number": "18",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "c3972a37",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110927114637_add_cached_tag_list_to_posts.rb",
"line_number": "4",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "a9b0384d",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110927114637_add_cached_tag_list_to_posts.rb",
"line_number": "5",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "a9b0384d",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110927114637_add_cached_tag_list_to_posts.rb",
"line_number": "6",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "a9b0384d",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110927115641_add_cached_tag_list_to_questions.rb",
"line_number": "4",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "a9b0384d",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110927115641_add_cached_tag_list_to_questions.rb",
"line_number": "5",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "a9b0384d",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview",
"short_filename": "db/migrate/20110927115641_add_cached_tag_list_to_questions.rb",
"line_number": "6",
"message": "use say with time in migrations",
"url": "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log",
"git_commit": "a9b0384d",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::UseMultipartAlternativeAsContentTypeOfEmailReview",
"short_filename": "app/mailers/notification_mailer.rb",
"line_number": "50",
"message": "use multipart/alternative as content_type of email",
"url": "http://rails-bestpractices.com/posts/41-use-multipart-alternative-as-content_type-of-email",
"git_commit": "a426b25c",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::RemoveEmptyHelpersReview",
"short_filename": "app/helpers/application_helper.rb",
"line_number": "1",
"message": "remove empty helpers",
"url": "http://rails-bestpractices.com/posts/72-remove-empty-helpers",
"git_commit": "0a20bef9",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview",
"short_filename": "app/models/job.rb",
"line_number": "44",
"message": "remove unused methods (Job#job_type_names)",
"url": "#",
"git_commit": "e2abac4b",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview",
"short_filename": "app/models/job.rb",
"line_number": "60",
"message": "remove unused methods (Job#publish!)",
"url": "#",
"git_commit": "476f7a0a",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview",
"short_filename": "app/models/post.rb",
"line_number": "76",
"message": "remove unused methods (Post#publish!)",
"url": "#",
"git_commit": "d27f5bbe",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview",
"short_filename": "app/models/question.rb",
"line_number": "30",
"message": "remove unused methods (Question#not_answered)",
"url": "#",
"git_commit": "0d6d7610",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Plugins::Reviews::NotUseRailsRootReview",
"short_filename": "app/mailers/notification_mailer.rb",
"line_number": "7",
"message": "not use RAILS_ROOT",
"url": "#",
"git_commit": "cc73fca1",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck",
"short_filename": "config/initializers/ckeditor.rb",
"line_number": "17",
"message": "remove trailing whitespace",
"url": "http://rails-bestpractices.com/posts/60-remove-trailing-whitespace",
"git_commit": "8c26bbcc",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck",
"short_filename": "lib/tasks/backup.rake",
"line_number": "2",
"message": "remove trailing whitespace",
"url": "http://rails-bestpractices.com/posts/60-remove-trailing-whitespace",
"git_commit": "ef01e997",
"git_username": "Richard Huang"
},
{
"type": "RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck",
"short_filename": "lib/tasks/cucumber.rake",
"line_number": "2",
"message": "remove trailing whitespace",
"url": "http://rails-bestpractices.com/posts/60-remove-trailing-whitespace",
"git_commit": "^6e95c37",
"git_username": "Richard Huang"
}
]
}
Jump to Line
Something went wrong with that request. Please try again.