Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
...
This comparison is big! We’re only showing the most recent 250 commits
Commits on Feb 03, 2012
@flyerhzm flyerhzm use option -L with git blame, no need to use sed 62cec06
Commits on Feb 05, 2012
@flyerhzm flyerhzm do not remove unused method in models reviews for to_param method 46b2e5c
Commits on Feb 13, 2012
@flyerhzm flyerhzm add not_use_time_ago_in_words_review 415168d
@flyerhzm flyerhzm update README eb37888
Commits on Feb 18, 2012
@flyerhzm flyerhzm ignore method_missing c9e1903
@flyerhzm flyerhzm do not detect as foreign key if no corresponding table fbcbbf9
Commits on Feb 19, 2012
@flyerhzm flyerhzm add table_name method to String 0778fa4
@flyerhzm flyerhzm after prepare process, fix incorrect associations' class_name b98cba3
@flyerhzm flyerhzm avoid call on Nil object 383c779
@flyerhzm flyerhzm ignore unused methods in Devise::OmniauthCallbacksController b0de60e
@flyerhzm flyerhzm ignore url_for method in remove_unused_methods_in_helpers_review cbd443c
@flyerhzm flyerhzm update pledgie embed code in README 7328b64
Commits on Feb 20, 2012
@flyerhzm flyerhzm add only option to parse specific files, it is really useful to debug 622e397
Commits on Feb 23, 2012
@flyerhzm flyerhzm mark methods used only when command message name is before and after e5bd10c
@flyerhzm flyerhzm better parse routes for nested resources 540cc3c
Commits on Feb 24, 2012
@flyerhzm flyerhzm parse get routes with to option ade4958
@flyerhzm flyerhzm Bumping version to 1.8.0 0fc95ff
@flyerhzm flyerhzm Bumping version to 1.8.0, last is a typoa 1baf2ec
@flyerhzm flyerhzm railsbp.com uses http now 9b5af11
Commits on Feb 25, 2012
@flyerhzm flyerhzm parse the route for scope with controller 67db875
@flyerhzm flyerhzm do not parse wrong route dc4cb76
Commits on Feb 26, 2012
@flyerhzm flyerhzm try ruby 1.9.3 43a5e21
Commits on Feb 27, 2012
@flyerhzm flyerhzm use vcall instead of var_ref in ruby 1.9.3 13c2cbc
@flyerhzm flyerhzm forgot to update ruby to 1.9.3 in travis c959740
@flyerhzm flyerhzm update scripts 5e35cab
@flyerhzm flyerhzm update README b1973b1
Commits on Feb 28, 2012
@flyerhzm flyerhzm parse nested scope routes 9cc4689
Commits on Mar 06, 2012
@flyerhzm flyerhzm rescue error and print useful debug info when parsing sexp node failed 844f48b
@flyerhzm flyerhzm throw is java's toy, in ruby it's raise 5ce5ecd
@flyerhzm flyerhzm get arguments for such syntax map(&:id) 816702b
@amutz amutz removing string injection in order to prevent problems with activerecord 2bfab5b
Commits on Mar 07, 2012
@flyerhzm flyerhzm add protect mass assignment check c42d5fd
@flyerhzm flyerhzm add protect mass assignment check to README and yml 5c9106b
@flyerhzm flyerhzm avoid protect mass assignment if using devise or authlogic 29949b3
@flyerhzm flyerhzm Merge pull request #105 from appfolio/remove_string_method_injection
removing string injection in order to prevent problems with activerecord
76161af
@flyerhzm flyerhzm Bumping version to 1.9.0 fac96b2
@flyerhzm flyerhzm update Gemfile.lock 41ab937
@flyerhzm flyerhzm add railsbp.com to README 9b5a8fd
@flyerhzm flyerhzm parse routes within namespace, but without controller f8119d5
Commits on Mar 08, 2012
@flyerhzm flyerhzm ignore more ActiveRecord built-in methods c1e7ba9
@flyerhzm flyerhzm custom_action for get/post 11abf95
Commits on Mar 14, 2012
@flyerhzm flyerhzm add brace_block support in routes 0aa6265
Commits on Mar 20, 2012
@harigopal harigopal attr_accessible can protect mass assignment without arguments 29b4fde
@flyerhzm flyerhzm Merge pull request #108 from harigopal/master
attr_accessible can be specified without arguments to block all
a810ed8
Commits on Mar 24, 2012
@flyerhzm flyerhzm remove .watchr.example cc708d2
@flyerhzm flyerhzm remove spork cde4e33
@flyerhzm flyerhzm do not support ripper in 1.8.7 2ed608b
Commits on Mar 28, 2012
@flyerhzm flyerhzm vcall in ruby 1.9.3 is same to var-ref in ruby 1.9.2 4fe5b70
@flyerhzm flyerhzm use module to simplify tests ef2e307
@flyerhzm flyerhzm fix typo 7430e57
@flyerhzm flyerhzm test both 1.9.2 and 1.9.3 in travis a351de3
@flyerhzm flyerhzm remove unnecessary RailsBestPractices namespace e6b5531
Commits on Mar 29, 2012
@flyerhzm flyerhzm add core/configs for rails config info e4b9088
@flyerhzm flyerhzm add config_prepare to remember rails configs 5cbea0a
@flyerhzm flyerhzm do not protect mass assignment if set config.active_record.whitelist_…
…attributes to true
ee48cef
@flyerhzm flyerhzm it is var_ref instead of vcall in 1.9.2 cf12373
Commits on Mar 31, 2012
@flyerhzm flyerhzm require awesome, and easy to debug 979b8b9
Commits on Apr 06, 2012
@flyerhzm flyerhzm delegate errors to runner in analyzer.rb 6819e68
@flyerhzm flyerhzm add attribute highlight to Error and with false by default d064306
@flyerhzm flyerhzm add errors_filter_block to allow change errors after analyzing 877f046
@flyerhzm flyerhzm set errors_filter_block as attr_accessor 14f2210
Commits on Apr 07, 2012
@flyerhzm flyerhzm memoize Runner#errors by instance variable 10b1ea4
@flyerhzm flyerhzm move analyze vcs into analyze method 269211c
Commits on Apr 19, 2012
@flyerhzm flyerhzm .try method is in core_ext/try in active_support 2.3.x a9bd5de
@flyerhzm flyerhzm clean test codes ea52bae
@flyerhzm flyerhzm Bumping version to 1.9.1 e91e9fd
@flyerhzm flyerhzm damn it, forgot to change error line after clean test codes ea93f55
@flyerhzm flyerhzm display resource/resources name in restrict_auto_generated_routes_rev…
…iew checker
612da8a
Commits on Apr 20, 2012
@flyerhzm flyerhzm display namespace and parent resources name in restrict_auto_generate…
…d_routes_review error
4168c7a
Commits on Apr 21, 2012
@flyerhzm flyerhzm get conditional_statement of ifop 1f73d46
@flyerhzm flyerhzm fix typo in README 295d570
Commits on May 19, 2012
@flyerhzm flyerhzm do not warn simplify render in views if there are some additional opt…
…ions, like :layout
ef6ed6a
Commits on May 27, 2012
@flyerhzm flyerhzm handle %w() in routes 829bcfc
@flyerhzm flyerhzm should skip :call as call message acdc7fd
Commits on May 28, 2012
@flyerhzm flyerhzm check method_node is equal to :call in mark_used method 94830e6
Commits on May 31, 2012
@dmasur dmasur Added a check for old 1.8 Hash Syntax 655465e
Commits on Jun 01, 2012
@emoreth emoreth Testing for ActiveRecord::Base inherit models only
Some times our models inherit from other models, specially when using
Single Table Inheritance. Those models should not be checked, once their
superclasses probably were.
df0c093
Commits on Jun 04, 2012
@flyerhzm flyerhzm Merge pull request #115 from TBAA/master
Added 1.8 Hash Syntax Check
5b8e4a9
@flyerhzm flyerhzm Merge pull request #114 from emoreth/protect_only_active_record_classes
Testing for ActiveRecord::Base inherit models only
eda4c12
@dmasur dmasur Added UseParenthesisInMethodDef 9e4f828
@emoreth emoreth Testing for ActiveRecord::Base inherit models only
Some times our models inherit from other models, specially when using
Single Table Inheritance. Those models should not be checked, once their
superclasses probably were.
bba5ab4
@dmasur dmasur Clean all warnings from the project itself 72c029e
@dmasur dmasur Fixing Typo d7c0466
@flyerhzm flyerhzm update ruby version and rb-fsevent, remove example files c813b6c
@flyerhzm flyerhzm Merge pull request #116 from TBAA/master
Added UseParenthesisInMethodDef
c5c7686
Commits on Jun 06, 2012
@dmasur dmasur Check for long lines 56a2a87
@dmasur dmasur Fixing some LongLine Warnings c9c9598
Commits on Jun 07, 2012
@flyerhzm flyerhzm sexp line for hash node 6e69867
@flyerhzm flyerhzm move lexicals/hash_syntax_check to reivews/hash_syntax_review, checki…
…ng string hash syntax as well
c9a6689
Commits on Jun 08, 2012
@flyerhzm flyerhzm add comments to hash_syntax_review 6f6cf5e
@dmasur dmasur Check for long lines 686bfaf
@dmasur dmasur Merge branch 'master' of git://github.com/railsbp/rails_best_practices
Conflicts:
	lib/rails_best_practices/lexicals.rb
9c6ca80
@dmasur dmasur Merge branch 'long_line'
Conflicts:
	lib/rails_best_practices/lexicals.rb
788117a
@dmasur dmasur Added Option to warn about StringHashes b16f1fa
Commits on Jun 18, 2012
@flyerhzm flyerhzm add only_symbol and only_string parameter to hash_syntax_review c67c4e6
Commits on Jun 19, 2012
@flyerhzm flyerhzm add comments to use_parenthese_in_method_def_review 7607401
@flyerhzm flyerhzm alphabetical order in rails_best_practices.yml and README 9c1384a
@flyerhzm flyerhzm merge TBAA long_line pull request 183fda2
@flyerhzm flyerhzm fix hash_syntax_syntax_review_spec 12ce24c
@flyerhzm flyerhzm comment LongLineCheck and chang default max_line_length to 80 characters dfbce56
@flyerhzm flyerhzm only_symbol and only_string are false as default 3f6530e
@flyerhzm flyerhzm do not check empty hash 336e26c
@flyerhzm flyerhzm Sexp#line for bare_assoc_hash 41a7c64
@flyerhzm flyerhzm Bumping version to 1.10.0 2f5d5d4
Commits on Jun 21, 2012
@flyerhzm flyerhzm update README bc192b8
@flyerhzm flyerhzm update README c68ff1f
@flyerhzm flyerhzm update README 25c79d4
@flyerhzm flyerhzm do not treat haml class node as hash syntax 9f66e9d
@inkstak inkstak Do not treat either ids nodes as hash syntax e1c3088
Commits on Jun 22, 2012
@flyerhzm flyerhzm Merge pull request #119 from blakink/master
Do not treat either ids nodes as hash syntax
34ce0a4
@dmasur dmasur Changed options to String, because the yaml returns Strings c69113a
Commits on Jun 23, 2012
@flyerhzm flyerhzm do not consider hash with array key and with invalid characters 16e2e90
@flyerhzm flyerhzm remove duplicate logic in hash syntax review 86bb3d8
@flyerhzm flyerhzm Bumping version to 1.10.1 83a78bb
Commits on Jun 28, 2012
@flyerhzm flyerhzm Merge pull request #121 from TBAA/master
My YAML Parser returned Strings instead of Keys.
78bbbd2
Commits on Jul 30, 2012
@mschuerig mschuerig Add a nicer result template. cd6da3b
Commits on Jul 31, 2012
@flyerhzm flyerhzm Merge pull request #123 from mschuerig/master
A nicer results template
51598e3
Commits on Aug 10, 2012
@flyerhzm flyerhzm update README b240a33
Commits on Aug 12, 2012
@flyerhzm flyerhzm install gemset in install_supported_rubies.sh 51a9278
@flyerhzm flyerhzm ruby 1.9 hash only replaces symbol hash 88a001f
@flyerhzm flyerhzm add app to controller, model, helper and view FILE regexp eba0c5b
Commits on Aug 14, 2012
@compactcode compactcode Mark action_controller layout methods as used. 11acb73
@flyerhzm flyerhzm Merge pull request #128 from compactcode/action_controller_layout_unu…
…sed_fix

Mark action_controller layout methods as used.
ce73dd5
Commits on Aug 27, 2012
@flyerhzm flyerhzm skip analyzing auto generated files, like db/schema.rb fd5ab8b
@flyerhzm flyerhzm LongLineCheck is disabled by default 99e8cbe
@flyerhzm flyerhzm no need to sort models, mailers, helpers and others internally e20c0fb
@flyerhzm flyerhzm add rabl support 472c363
@flyerhzm flyerhzm add test for all arguments with command_call node 3cec758
Commits on Sep 03, 2012
@flyerhzm flyerhzm initialize lexical, prepares and reviews checking_visitor in differen…
…t objects
d072071
Commits on Sep 04, 2012
@flyerhzm flyerhzm abstract code_analyzer 9a9b8ed
@flyerhzm flyerhzm add AnalyzerException 2c7f007
@flyerhzm flyerhzm test default CheckingVisitor 9a56966
@flyerhzm flyerhzm remove rails_best_practices checking_visitor d7bb800
@flyerhzm flyerhzm forgot to remove the file 5e94d8f
@flyerhzm flyerhzm move sexp and nil to code_analyzer 3f20311
@flyerhzm flyerhzm fix sexp test in 1.9.2 94dbabb
@flyerhzm flyerhzm fix sexp test in 1.9.2 eb43bf7
@flyerhzm flyerhzm move interesting_nodes and interesting_files to CodeAnalyzer 279d840
@flyerhzm flyerhzm use add_callback for each checker 3233ec2
@flyerhzm flyerhzm add Warning to code_analyzer f35a2b1
@flyerhzm flyerhzm move callbacks to CodeAnalyzer 475f5f3
@flyerhzm flyerhzm add after_check to code_analyzer 569e581
@flyerhzm flyerhzm callback names should be symbol df2a9c2
@flyerhzm flyerhzm add Check.url method 1c8d359
@flyerhzm flyerhzm move dups method in add_model_virtual_attribute_review, where is the …
…only place to call dups
42226fb
@flyerhzm flyerhzm LongLineCheck should require core/check 423f8b4
@flyerhzm flyerhzm rename Sexp#subject to Sexp#receiver fdf52a0
@flyerhzm flyerhzm debug and without-color options should not be used in Runner 20c869b
@flyerhzm flyerhzm extract code_analyzer gem 763518a
@flyerhzm flyerhzm merge refactor gem b3a4721
Commits on Sep 06, 2012
@flyerhzm flyerhzm set UseBeforeFilterCheck and RemoveTabCheck disabled by default which
is not agreed by other devs
set HashSyntaxCheck, LongLineCheck and UseParenthesesInMethodDefCheck
disabled by default which is not said on rails-bestpractices.com
c1a70a0
Commits on Sep 07, 2012
@flyerhzm flyerhzm update README to say we support rabl 6375863
@flyerhzm flyerhzm update README to say some checks are disabled by default 6aea333
@flyerhzm flyerhzm ignore Gemfile.lock a321c53
Commits on Sep 12, 2012
@flyerhzm flyerhzm fix typo 567f6af
Commits on Sep 22, 2012
@flyerhzm flyerhzm Bumping version to 1.11.1 c205a29
Commits on Sep 24, 2012
@flyerhzm flyerhzm ProtectMassAssignmentChecker supports strong_parameters gem now 38e3771
Commits on Oct 02, 2012
@flyerhzm flyerhzm use && instead of ; for multiple shell commands 03e9b9a
Commits on Oct 06, 2012
@justindell justindell fix bug when creating html with no errors present 368929a
Commits on Oct 07, 2012
@flyerhzm flyerhzm Merge pull request #134 from justindell/master
Fix bug when creating html with no errors present
ad9bafc
Commits on Oct 09, 2012
@flyerhzm flyerhzm don't remove empty application_helper.rb b2da8d0
@flyerhzm flyerhzm remove errors_filter_block 45e5a4f
@flyerhzm flyerhzm add yaml output 3dc0db5
@flyerhzm flyerhzm analyze_vcs for yaml format as well cc95a61
@flyerhzm flyerhzm remove Error#highlight 92a59df
Commits on Oct 24, 2012
@RichardBradley RichardBradley Add support for t.index style indices in schema.rb, as added by e.g. …
…schema_plus
cb7fd3f
Commits on Oct 25, 2012
@flyerhzm flyerhzm Merge pull request #135 from RichardBradley/master
fix index required false-positive
063ce52
Commits on Oct 29, 2012
@RichardBradley RichardBradley Disallow catching 'Exception' -- a common mistake by Java or C# devs …
…in ruby
7267792
Commits on Nov 02, 2012
@flyerhzm flyerhzm Merge pull request #137 from RichardBradley/not_rescue_exception
Disallow catching 'Exception'
2153220
@flyerhzm flyerhzm change url for NotRescueExceptionReview 1273743
@flyerhzm flyerhzm should not set execute permission for not_rescue_exception_review 9d1f62b
@flyerhzm flyerhzm refactor not_rescue_exception_review to use exception_classes api of …
…rescue node
082f52b
@flyerhzm flyerhzm say we added "NotRescueExceptionCheck" in README c022050
@flyerhzm flyerhzm Bumping version to 1.12.0 a6e8dca
Commits on Nov 03, 2012
@RichardBradley RichardBradley Add check save return value review 03e836b
Commits on Nov 05, 2012
@RichardBradley RichardBradley Reduce false-positives in RemoveUnusedMethodsInControllersReview by e…
…nhancing Routes to be aware of member actions in resources blocks
7d70afb
Commits on Nov 06, 2012
@flyerhzm flyerhzm Merge pull request #139 from RichardBradley/resources_member_actions
Reduce false-positives in RemoveUnusedMethodsInControllersReview
b3d39e0
@RichardBradley RichardBradley Make check_save_return_value look for Model classes as the receiver o…
…f "create" to reduce false-positives
71e41cd
Commits on Nov 07, 2012
@flyerhzm flyerhzm Merge pull request #138 from RichardBradley/check_save_return_value
Add check save return value review
8bbe6b7
Commits on Nov 23, 2012
@flyerhzm flyerhzm update ruby 1.9.3 24705ff
@flyerhzm flyerhzm add GemfilePrepare to remember all gems 7043440
@flyerhzm flyerhzm add use_turbo_sprockets_rails3 checker to speed up assets:precompile 06ce8b4
@flyerhzm flyerhzm add use turbo-sprockets-rails3 to README 8711592
@flyerhzm flyerhzm Bumping version to 1.13.0 66bdb58
Commits on Dec 03, 2012
@flyerhzm flyerhzm use rvm default ruby 2918d33
@flyerhzm flyerhzm check save return value in elsif node 8bac343
@flyerhzm flyerhzm Bumping version to 1.13.1 7a36704
Commits on Dec 18, 2012
@flyerhzm flyerhzm check ifop, if_mod and unless_mod nodes as well d530c89
@flyerhzm flyerhzm Bumping version to 1.13.2 3d73975
Commits on Jan 23, 2013
@shanesveller shanesveller Update progressbar syntax to silence new deprecation warnings
$ rails_best_practices
DEPRECATION WARNING: Requiring ruby-progressbar using `require progressbar` or `gem progressbar` has been deprecated and will be disabled on or after June 30th, 2013.  Please use `require ruby-progressbar` or `gem ruby-progressbar` instead
DEPRECATION WARNING: Calling `ProgressBar.new` is deprecated and will be removed on or after June 30th, 2013.  Please use `ProgressBar.create` instead.
DEPRECATION WARNING: Creating progress bars using ProgressBar.new(title, total, output_io) has been deprecated and will be removed on or after June 30th, 2013.  Please use ProgressBar.create(:title => title, :total => total, :output => output_io) instead. The full list of options can be found here: https://github.com/jfelchner/ruby-progressbar.
DEPRECATION WARNING: #inc will be removed on or after June 30th, 2013. Please use #increment instead.                                                                              |
Analyzing: |=======================================================================================================================================================================|
Analyzing: |=======================================================================================================================================================================|
c608792
@shanesveller shanesveller Inc is also deprecated to Increment 15b4b11
Commits on Jan 24, 2013
@flyerhzm flyerhzm Merge pull request #146 from shanesveller/ruby-progressbar
Update ruby-progressbar syntax
7f93489
@flyerhzm flyerhzm update README dc50dcd
@flyerhzm flyerhzm Bumping version to 1.13.3 3a9f213
Commits on Jan 30, 2013
@bf4 bf4 Note incompatibility with ruby 1.8 458295f
@bf4 bf4 Update gemspec to exclude rubies less than 1.9 4868668
Commits on Jan 31, 2013
@deiga deiga Update README.md efe8138
@deiga deiga Update lib/rails_best_practices/analyzer.rb 16cf234
@deiga deiga Update assets/result.html.erb d54459f
@deiga deiga Update README.md fd01b24
@deiga deiga Update lib/rails_best_practices/command.rb 949fc15
Commits on Feb 04, 2013
@DarkTatka DarkTatka Added --with-github GITHUB_NAME to Readme
When quickly scanning this project, awfully helpful option like --with-github can be missed.
8831751
Commits on Feb 07, 2013
@flyerhzm flyerhzm Merge pull request #147 from metricfu/master
Not compatible with ruby < 1.9
64cb614
@flyerhzm flyerhzm Merge pull request #148 from deiga/master
Adding the option of opening files with Sublime Text 2
9b7a9c5
@flyerhzm flyerhzm Merge pull request #149 from DarkTatka/readme-addition
Added --with-github GITHUB_NAME to Readme
f1b0d30
@nikitachernov nikitachernov Typo fix in Analyzer b64b0de
@flyerhzm flyerhzm Merge pull request #150 from nikitachernov/patch-1
Typo fix in Analyzer
7f18791
Commits on Feb 08, 2013
@flyerhzm flyerhzm Bumping version to 1.13.4 4c42304
Commits on Mar 22, 2013
@cschramm cschramm Bind check of whitelist_attributes to usage of attr_protected or attr…
…_accessible
661c73a
@yjpa7145 yjpa7145 Updated gemfile to use https 3633784
Commits on Mar 25, 2013
@yjpa7145 yjpa7145 Fixed bug where filtered directories in the path cause all files to b…
…e excluded
9981a5d
Commits on Mar 28, 2013
@flyerhzm flyerhzm Merge pull request #152 from cschramm/master
Fix ForbiddenAttributesProtection false positive
707212a
@flyerhzm flyerhzm Merge pull request #153 from mhuffnagle/GemfileUseSSL
Bundler issues deprecation warning
bc76938
@flyerhzm flyerhzm Merge pull request #154 from mhuffnagle/PathBug
No files checked when the path contains a directory excluded by default
bfce37b
@flyerhzm flyerhzm run ruby 2.0.0 on travis de9aa41
@flyerhzm flyerhzm IO.write does not work on ruby 1.9.2 e713cb8
Commits on Apr 06, 2013
Dave Golombek Extend with-github flag to take full path to GitHub:FI repos
For using rails_best_practices when you have a private github server
that you'd like to link to.
979f064
Commits on Apr 10, 2013
@flyerhzm flyerhzm Merge pull request #158 from dgolombek/master
Extend with-github flag to take full path to GitHub:FI repos
2f3a03d
Commits on Apr 26, 2013
@4r2r 4r2r Fix: methods from the module should not be added to models
Issue description:
1. Create a module under app/models
2. Create a pair of models under app/models
3. Observe that methods from this module are assigned to the model
176e82d
@flyerhzm flyerhzm Merge pull request #161 from 4r2r/fix-adding-methods-from-modules
Fix: methods from the module should not be added to models
24f08b2
Commits on Apr 29, 2013
@flyerhzm flyerhzm add coverall dd232bf
@flyerhzm flyerhzm coverall badge 2978486
@flyerhzm flyerhzm update README e672a87
@4r2r 4r2r Fix Analyzer#file_ignore failure when pattern.class == RegExp
How to reproduce:

1.  Create a new instance of analyzer: `analyzer = Analyzer.new('.')`
2.  Observe that `analyzer.file_ignore(%w[ ... ], /regexp-pattern/)`
    raises undefined method 'end_with?' error
3.  Observe that documentation for Analyzer#file_ignore states
    that it accepts regular expressions as pattern
52087dc
Commits on May 02, 2013
@flyerhzm flyerhzm Merge pull request #162 from 4r2r/fix-file-ignore-bug
Fix Analyzer#file_ignore failure when pattern.class == RegExp
751b514
Commits on May 06, 2013
@flyerhzm flyerhzm set CheckSaveReturnValueCheck disable by default ba3f587
@flyerhzm flyerhzm Bumping version to 1.13.5 3f3b6df
Commits on Jun 01, 2013
@flyerhzm flyerhzm switch .rvmrc to .ruby-version and .ruby-gemset eb64ae4
@flyerhzm flyerhzm add .coveralls.yml to .gitignore 2d500a8
Commits on Jun 14, 2013
@flyerhzm flyerhzm ignore unused method as_json in models #168 65758de
@flyerhzm flyerhzm check assig node in lib/reviews/remove_unused_methods_in_controller_r…
…eview
50ea9ab
@flyerhzm flyerhzm check if ActiveRecord include ActiveModel::ForbiddenAttributesProtect…
…ion in initializers
80d3025
@flyerhzm flyerhzm add comment 9657d91
@flyerhzm flyerhzm read Gemfile.lock, save gem with version in GemfilePrepare 5d90cb5
@flyerhzm flyerhzm do not check protect mass assignment for rails 4 5327405
@flyerhzm flyerhzm use except if only message is too long 7affbce
@flyerhzm flyerhzm output warning if directory doesn't exist c303ab9
@flyerhzm flyerhzm Bumping version to 1.13.6 520b421
Commits on Jun 15, 2013
@flyerhzm flyerhzm hotfix for ARGV.first is nil #169 5452d9a
@flyerhzm flyerhzm Bumping verion to 1.13.7 a419d63
Commits on Jun 21, 2013
@flyerhzm flyerhzm use latest ruby 2.0.0 7ab95ee
@flyerhzm flyerhzm also check Gemfile.lock #170 b2fd0fd
@flyerhzm flyerhzm Bumping version to 1.13.8 8e4bee6
Commits on Jul 08, 2013
@kassi kassi Fix broken sublime-text links a2a7602
Commits on Jul 09, 2013
@flyerhzm flyerhzm Merge pull request #171 from kassi/sublime-links
Fix broken sublime-text links
ed4064a
Commits on Jul 21, 2013
@flyerhzm flyerhzm add default_scope is evil check a7bdd17
@flyerhzm flyerhzm add DefaultScopeIsEvilCheck to rails_best_practices.yml and README 03127d4
@flyerhzm flyerhzm require files by alphabetical order 6f737c6
@flyerhzm flyerhzm use require_all to simplify require dependency 48c6b2a
@flyerhzm flyerhzm Bumping version to 1.14.0 60f53ab