Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

warn about allowing a login shell in the terminal emulator #19

Merged
merged 1 commit into from Dec 6, 2013

Conversation

Projects
None yet
2 participants
Contributor

givanse commented Dec 4, 2013

RVM does not work properly if it is run from terminal emulator that does not allow a login shell. The behaviour is easy to see by just trying to run:
$ rvm use

The scenario is well handled by RVM and instructions are given to the user. However, the rails install script encapsulates RVM and will never face a situation like this because, in line 16, the rvm script is being sourced.

The shell used for installation will display correctly the version numbers for Ruby and Rails, but once it exits the configuration will be lost.

I saw this behaviour in gnome-terminal, xterm and uxterm.

warn about enabling login shell in the terminal emulator
RVM does not work properly if it is run from terminal emulator that does not allow a login shell. The behaviour is easy to see by just trying to run: 
    $ rvm use

The scenario is well handled by RVM and instructions are given to the user. However, the rails install script encapsulates RVM and will never face a situation like this because, in line 16, the rvm script is being sourced.

The shell used for installation will display correctly the version numbers for Ruby and Rails, but once it exits the configuration will be lost.

I saw this behaviour in gnome-terminal, xterm and uxterm.

vesan added a commit that referenced this pull request Dec 6, 2013

Merge pull request #19 from givanse/patch-2
warn about allowing a login shell in the terminal emulator

@vesan vesan merged commit b622981 into railsgirls:master Dec 6, 2013

@givanse givanse deleted the givanse:patch-2 branch Jan 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment