Upgrade Bulma to not rely on rails-assets. (#217)

There was some chatter about not relying on rails-assets in Slack. This PR updates Bulma to not use it and instead use the yarn package.
railslink · Oct 16, 2021 · d011328 · d011328
1 parent 07e0bdd
commit d011328
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/Gemfile b/Gemfile
@@ -26,7 +26,6 @@ gem 'pg', '< 2.0'                                                  # use postgre
 gem 'pagy'                                                         # pagination ruby gem
 gem 'puma'                                                         # use puma as the app server
 gem 'rack-attack'                                                  # rack middleware for blocking & throttling abusive requests
-gem 'rails-assets-bulma', source: 'https://rails-assets.org'       # modern css framework based on flexbox
 gem 'rails-assets-chartjs', source: 'https://rails-assets.org'     # html5 charts using the canvas element
 gem 'rails-assets-fontawesome', source: 'https://rails-assets.org' # iconic svg, font, and css toolkit
 gem 'redis'                                                        # client that tries to match redis' api one-to-one, while still providing an idiomatic interface

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -171,7 +171,6 @@ GEM
       bundler (>= 1.3.0)
       railties (= 5.2.6)
       sprockets-rails (>= 2.0.0)
-    rails-assets-bulma (0.7.4)
     rails-assets-chartjs (2.8.0)
     rails-assets-fontawesome (5.10.1)
     rails-dom-testing (2.0.3)
@@ -308,7 +307,6 @@ DEPENDENCIES
   puma
   rack-attack
   rails (~> 5.2)
-  rails-assets-bulma!
   rails-assets-chartjs!
   rails-assets-fontawesome!
   redis

diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss
@@ -4,7 +4,7 @@ $family-sans-serif: 'Cabin', -apple-system, blinkmacsystemfont, "Segoe UI", robo
 $notification-padding: 0.75rem 2.5rem 0.75rem 1.5rem;
 
 @import url("//fonts.googleapis.com/css?family=Cabin");
-@import "bulma";
+@import "bulma/bulma.sass";
 @import "bulma-overrides";
 
 body.c-home {

diff --git a/package.json b/package.json
@@ -2,6 +2,7 @@
   "name": "ruby_on_rails_link",
   "private": true,
   "dependencies": {
+    "bulma": "^0.9.3",
     "stylelint": "^13.13.1",
     "stylelint-config-standard": "^22.0.0"
   }

diff --git a/yarn.lock b/yarn.lock
@@ -387,6 +387,11 @@ browserslist@^4.12.0, browserslist@^4.14.5:
     escalade "^3.1.1"
     node-releases "^1.1.71"
 
+bulma@^0.9.3:
+  version "0.9.3"
+  resolved "https://registry.yarnpkg.com/bulma/-/bulma-0.9.3.tgz#ddccb7436ebe3e21bf47afe01d3c43a296b70243"
+  integrity sha512-0d7GNW1PY4ud8TWxdNcP6Cc8Bu7MxcntD/RRLGWuiw/s0a9P+XlH/6QoOIrmbj6o8WWJzJYhytiu9nFjTszk1g==
+
 callsites@^3.0.0:
   version "3.1.0"
   resolved "https://registry.yarnpkg.com/callsites/-/callsites-3.1.0.tgz#b3630abd8943432f54b3f0519238e33cd7df2f73"