Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RoundButtonSizeToggler component with Reanimated 1 usage #3321

Merged
merged 2 commits into from May 13, 2022
Merged

Remove unused RoundButtonSizeToggler component with Reanimated 1 usage #3321

merged 2 commits into from May 13, 2022

Conversation

jkadamczyk
Copy link
Contributor

Fixes RNBW-3384

What changed (plus any additional context for devs)

  • Removed unused RoundButtonSizeToggler component with Reanimated 1 usage

Dev checklist for QA: what to test

  • check preview, the app should work fine without it (no usages were found)

Final checklist

  • Assigned individual reviewers?
  • Added labels?
  • Added e2e tests? if not please specify why – just removed a component
  • If you added new files, did you update the CODEOWNERS file?

@jkadamczyk jkadamczyk added needs dev review Includes code review AND testing out the branch performance performance related improvements labels May 10, 2022
@linear
Copy link

linear bot commented May 10, 2022

RNBW-3384 Remove Reanimated 1 from RoundButtonSizeToggler

@jkadamczyk
Copy link
Contributor Author

/preview

tchayen
tchayen approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@tchayen tchayen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

brunobar79
brunobar79 approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jkadamczyk jkadamczyk force-pushed the @jkadamczyk/remove-round-button-size-toggler branch from ec3e873 to 2668cb9 Compare May 12, 2022 08:42
@jkadamczyk
Copy link
Contributor Author

Seems like linter still complains gotta check it out it was clean "on my machine"

@jkadamczyk
Copy link
Contributor Author

should be good now

@jkadamczyk jkadamczyk merged commit 0a47efb into develop May 13, 2022
@jkadamczyk jkadamczyk deleted the @jkadamczyk/remove-round-button-size-toggler branch May 13, 2022 07:43
l2succes pushed a commit that referenced this pull request Jun 8, 2022
@jkadamczyk @l2succes
Remove unused RoundButtonSizeToggler component with Reanimated 1 usage (
8e44cfe 
#3321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@tchayen tchayen tchayen approved these changes

@terrysahaidak terrysahaidak terrysahaidak approved these changes

@jinchung jinchung Awaiting requested review from jinchung

@osdnk osdnk Awaiting requested review from osdnk

Assignees
No one assigned
Labels
needs dev review Includes code review AND testing out the branch performance performance related improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkadamczyk @brunobar79 @tchayen @terrysahaidak