Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] signMessage Does Not Launch Rainbow/Metamask on Android #387

Closed
1 task done
nickcherry opened this issue May 16, 2022 · 2 comments · Fixed by #515
Closed
1 task done

[bug] signMessage Does Not Launch Rainbow/Metamask on Android #387

nickcherry opened this issue May 16, 2022 · 2 comments · Fixed by #515
Labels
bug Something isn't working

Comments

@nickcherry
Copy link

nickcherry commented May 16, 2022

Is there an existing issue for this?

  • I have searched the existing issues

RainbowKit Version

0.1.0

wagmi Version

0.3.5

Current Behavior

When calling signMessage within the Chrome browser on an Android device, there is haptic feedback, but the wallet app (e.g. Rainbow, MetaMask) is not launched / brought to the foreground, requiring that the user manually open the wallet app to find the sign message prompt.

Expected Behavior

I would expect the connected wallet (e.g. Rainbow, MetaMask) to be launched / brought to the foreground, similar to the experience of connecting a wallet. See also #460.

Steps To Reproduce

  1. In Chrome on an Android device, navigate to https://neon-griffin-f8c8b4.netlify.app/
  2. Connect to Rainbow or MetaMask.
  3. Press "Sign Message" and observe that while there is haptic feedback, the wallet app is not brought to the foreground.

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://github.com/nickcherry/rainbowkit-test

Anything else?

No response

@nickbytes
Copy link
Collaborator

Hey sorry for no update here! We're looking into Android + general deeplinking issues. We've found some improvements that can be made to RainbowKit, as well as some app improvements that need to be made. Will update you more shortly!

@markdalgleish
Copy link
Contributor

I realised this is because we weren't detecting wc: URIs when saving the WALLETCONNECT_DEEPLINK_CHOICE setting to local storage which is what WalletConnect uses for deep linking. I've opened a PR fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants