Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] No Feedback When Calling signMessage on iOS When In Do Not Disturb #460

Closed
1 task done
nickcherry opened this issue Jun 2, 2022 · 4 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@nickcherry
Copy link

nickcherry commented Jun 2, 2022

Is there an existing issue for this?

  • I have searched the existing issues

RainbowKit Version

0.1.0

wagmi Version

0.3.5

Current Behavior

When calling signMessage within Safari on an iOS device that is in Do Not Disturb mode, the message-to-be-signed is queued in the wallet app (e.g. Rainbow, Metamask), but the user receives no feedback.

Expected Behavior

I would expect the connected wallet (e.g. Rainbow, MetaMask) to be launched / brought to the foreground, similar to the experience of connecting a wallet. See also #387.

Steps To Reproduce

  1. In Safari on an iOS device, navigate to https://neon-griffin-f8c8b4.netlify.app/
  2. From the iOS Control Center, enable Do Not Disturb mode.
  3. Connect to Rainbow or MetaMask.
  4. Press "Sign Message" and observe that there is no feedback.

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://github.com/nickcherry/rainbowkit-test

Anything else?

No response

@markdalgleish
Copy link
Contributor

I wasn't able to reproduce this on an iPhone 12 Pro running iOS 15.5, even using the link that you shared. Are you still experiencing this issue?

@nickcherry
Copy link
Author

nickcherry commented Jun 22, 2022

Yeah, I'm still seeing the issue with the example app. I'm also running iOS 15.5 on an iPhone 12 Pro. This is what the experience looks like for me:

rainbow-dnd.mov

Update Also, my Do Not Disturb settings can be found below. If you add Rainbow to the list of allowed apps, the push notification will be presented and the the flow will work as expected. I think the default iOS behavior is to not show notifications for any apps, though.

@markdalgleish
Copy link
Contributor

markdalgleish commented Jun 27, 2022

In your video you're not being taken to the native app when tapping "Sign Message". It works for me using the example link you shared.

In your original issue it says you're running RainbowKit v0.1.0 but the deep linking fixes were published later than this. Have you since upgraded RainbowKit in your example? If so, can you try disconnecting and reconnecting your wallet? This ensures the WalletConnect local storage value for deep linking is set correctly. It's called WALLETCONNECT_DEEPLINK_CHOICE if you want to debug further.

@nickcherry
Copy link
Author

Yeah, this is with RainbowKit v0.1.0, so that is a good point. This is probably moot given the deeplink change. Gonna close this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants