Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cint with lodash and native functions #677

Merged
merged 6 commits into from May 25, 2020
Merged

Conversation

raineorshine
Copy link
Owner

I found replacements for everything but the following cint functions:

  • cint.filterObject
  • cint.mapObject
  • cint.toArray
  • cint.toObject

@XhmikosR I don't see equivalent functions in lodash, so I think I will have to keep cint as a dependency. I prefer that over inlining the cint functions. It is better than before at least.

@XhmikosR
Copy link
Collaborator

XhmikosR commented May 19, 2020

BTW @raineorshine that's why I suggested adapting the Coveralls threshold 😛

0.5% or half should be better.

0.5% or 50%? Or do you mean something else by half?

Also, you probably shouldn't require Coveralls to pass in the branch protections; I'd stick with the Actions workflows only

Unfortunately I'm not familiar enough with Coveralls to know what you mean here. Could you explain this? I unchecked "Branch Coverage". Is that what you meant? Thanks!

@XhmikosR
Copy link
Collaborator

XhmikosR commented May 25, 2020

@raineorshine you edited my message hence I wasn't notified :/

Just use 0.5% as the failure threshold and see how it goes. EDIT: or even bigger like 1, 2%.

About NOT requiring coveralls, this should be done in the repo branch protection settings.

@raineorshine
Copy link
Owner Author

@raineorshine you edited my message hence I wasn't notified :/

Oops!

Just use 0.5% as the failure threshold and see how it goes. EDIT: or even bigger like 1, 2%.

About NOT requiring coveralls, this should be done in the repo branch protection settings.

I see. Done!

@raineorshine raineorshine merged commit 5ef858f into master May 25, 2020
@raineorshine raineorshine deleted the replace-cint branch May 25, 2020 14:12
@XhmikosR
Copy link
Collaborator

@raineorshine I have a couple of patches that won't apply to current master, but I could update them if you are interested: master...XhmikosR:xo Ignore all patches minus the "Replace..." ones 🙂

@raineorshine
Copy link
Owner Author

@raineorshine I have a couple of patches that won't apply to current master, but I could update them if you are interested: master...XhmikosR:xo Ignore all patches minus the "Replace..." ones 🙂

Thanks, but I think it's okay without them. _.last works fine and the reverse technique is a bit worse performance-wise.

@XhmikosR
Copy link
Collaborator

Yup, that's why I hadn't made PRs. All good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants