New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cint with lodash and native functions #677
Conversation
BTW @raineorshine that's why I suggested adapting the Coveralls threshold 😛
0.5% or 50%? Or do you mean something else by half?
Unfortunately I'm not familiar enough with Coveralls to know what you mean here. Could you explain this? I unchecked "Branch Coverage". Is that what you meant? Thanks! |
@raineorshine you edited my message hence I wasn't notified :/ Just use 0.5% as the failure threshold and see how it goes. EDIT: or even bigger like 1, 2%. About NOT requiring coveralls, this should be done in the repo branch protection settings. |
Oops!
I see. Done! |
@raineorshine I have a couple of patches that won't apply to current master, but I could update them if you are interested: master...XhmikosR:xo Ignore all patches minus the "Replace..." ones 🙂 |
Thanks, but I think it's okay without them. |
Yup, that's why I hadn't made PRs. All good! |
I found replacements for everything but the following cint functions:
cint.filterObject
cint.mapObject
cint.toArray
cint.toObject
@XhmikosR I don't see equivalent functions in
lodash
, so I think I will have to keepcint
as a dependency. I prefer that over inlining the cint functions. It is better than before at least.