Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Wow64*Wow64FsRedirection functions dynamically to support Windows XP #4

Conversation

denis-sh
Copy link
Contributor

@denis-sh denis-sh commented Dec 2, 2015

TRY_LOAD_WINAPI_FUNC macro was introduced for this purpose:

#define TRY_LOAD_WINAPI_FUNC(module, type, name, params) \
    typedef type (WINAPI *name ## Ptr) params; \
    name ## Ptr name = reinterpret_cast<name ## Ptr>(GetProcAddress(module, #name));

@denis-sh
Copy link
Contributor Author

denis-sh commented Dec 2, 2015

Also reopened Issue 12565 until this is merged and no other problems occurred.

@PetarKirov
Copy link

Btw, I think that now DMD does not support Windows XP officially, but there's harm in removing limitations such as this from VisualD.

@denis-sh
Copy link
Contributor Author

denis-sh commented Dec 2, 2015

Btw, I think that now DMD does not support Windows XP officially, but there's harm in removing limitations such as this from VisualD.

Citing Walter's post:

As a practical matter, we do not test on XP, and so it is disingenuous to claim official support for it.

I suggest saying we "officially" support Win7 or later, and unofficially support versions back to XP. Unofficially means there's code there to support it, and we accept pull requests to fix bugs in it, we will try not to break it, but we don't test or guarantee that it'll work.

@rainers
Copy link
Owner

rainers commented Dec 2, 2015

but there's harm in removing limitations such as this from VisualD

I guess you meant "no harm"?

@rainers
Copy link
Owner

rainers commented Dec 2, 2015

Thanks. LGTM, T'll have to have to merge without testing on XP, though.

rainers added a commit that referenced this pull request Dec 2, 2015
…ctions-dynamically

Load Wow64*Wow64FsRedirection functions dynamically to support Windows XP
@rainers rainers merged commit d4c70e0 into rainers:master Dec 2, 2015
@denis-sh
Copy link
Contributor Author

denis-sh commented Dec 3, 2015

Thanks. LGTM, T'll have to have to merge without testing on XP, though.

I can test if you make a binary available to download.

@rainers
Copy link
Owner

rainers commented Dec 4, 2015

I can test if you make a binary available to download.

You can download it here: https://gist.github.com/rainers/6cdf73b48837defb9f88/raw/7c2dcf8f07c50825887df896fe4d94d2f8cf089c/MagoNatDE.dll

Just replace the DLL in the VisualD/mago folder.

@denis-sh
Copy link
Contributor Author

denis-sh commented Dec 4, 2015

You can download it here

Works well on Windows XP. Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants