New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS class to Tabs #180

Open
Alex360hd opened this Issue Sep 30, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Alex360hd

Alex360hd commented Sep 30, 2017

Hello,

It would be great to be able to add CSS class to primary and secondary tabs on backend form.

For example to manage padded-pane tabs, I noticed that you had to use javascript in you rainlab blog plugin in order to put some padding to tabs that does not contain the markdown widget.

To me, it's an ugly way to do and adding the possibility to put custom CSS class to tabs would be better.

What do you think about it ?

Regards,

@LukeTowers

This comment has been minimized.

Show comment
Hide comment
@LukeTowers

LukeTowers Sep 30, 2017

Member

Currently October only supports adding css classes to the tab or secondaryTab container as a whole, does this still fit what you have in mind?

Member

LukeTowers commented Sep 30, 2017

Currently October only supports adding css classes to the tab or secondaryTab container as a whole, does this still fit what you have in mind?

@Alex360hd

This comment has been minimized.

Show comment
Hide comment
@Alex360hd

Alex360hd Oct 2, 2017

Not sure, the idea is to be able to add "padded-pane" class to tabs that require some padding when you create your form with the "fancy-layout" style (same than rainlab blog with orange header) without javascript.

Not a big issue as you have tools to add some javascript to backend, but using javascript to do that is not very elegant.

Alex360hd commented Oct 2, 2017

Not sure, the idea is to be able to add "padded-pane" class to tabs that require some padding when you create your form with the "fancy-layout" style (same than rainlab blog with orange header) without javascript.

Not a big issue as you have tools to add some javascript to backend, but using javascript to do that is not very elegant.

@LukeTowers

This comment has been minimized.

Show comment
Hide comment
@LukeTowers

LukeTowers Oct 3, 2017

Member

Well the way tabs currently work in October you can't really specify a per tab config item within a container as the individual tabs within a container are just generated from the fields that say they use the applicable tabs.

Member

LukeTowers commented Oct 3, 2017

Well the way tabs currently work in October you can't really specify a per tab config item within a container as the individual tabs within a container are just generated from the fields that say they use the applicable tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment