Fix ctrl+k not working & being captured by browser#9
Merged
rajasimon merged 2 commits intorajasimon:mainfrom Nov 25, 2022
Merged
Fix ctrl+k not working & being captured by browser#9rajasimon merged 2 commits intorajasimon:mainfrom
rajasimon merged 2 commits intorajasimon:mainfrom
Conversation
Owner
|
@jgillard can you confirm this works in your machine? |
Contributor
Author
Also, can anyone confirm if it works on Mac? |
Owner
|
@EnriqueSoria yeah I'm on Mac let me check quickly... |
Owner
|
Confirmed! It's working for Mac ( Safari, Chrome, firefox ) |
Contributor
|
I've tested this with Chrome & Safari on Mac, Chrome & Edge on Windows (VM), and my team has tested it with 2 flavours of Linux, and everyone is happy. |
Contributor
Author
|
I'm impressed how fast have this gone... yesterday I didn't even know this package existed! Thanks for reviewing this PR in such a small amount of time! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this changes it works for me both on Firefox and Chrome (on Ubuntu 20.04). Fixes #8