New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation hook #9

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rajatjindal
Copy link
Owner

rajatjindal commented Feb 2, 2019

This PR will make sure we can handle installation and installation_repositories event too. and tweet a welcome msg for the new onboarded projects.

@rajatjindal rajatjindal force-pushed the add-installation-hook branch from 91011d4 to 01470a8 Feb 2, 2019

@rajatjindal rajatjindal requested a review from alexellis Feb 2, 2019

@@ -21,6 +23,13 @@ func init() {
twitterClient, twitterClientInitErr = twitter.NewClient()
}

// func main() {

This comment has been minimized.

@alexellis

alexellis Feb 2, 2019

Collaborator

Maybe this could be removed?

@rajatjindal

This comment has been minimized.

Copy link
Owner Author

rajatjindal commented Feb 2, 2019

Hi @alexellis

thanks for all the feedback you have provided so far. I hope you don't mind reviewing the PR for me.

Thanks
Rajat Jindal

// deprecated and replaced by installation and installation_repositories. But github is still sending integration_installation and
// integration_installation_repositories and go-github don't understand these.

switch t {

This comment has been minimized.

@alexellis

alexellis Feb 2, 2019

Collaborator

What about removal events? (are they correctly ignored?)

This code should be a function and tested 👍

w.Write([]byte("OK"))
}

func handleIssuesEvent(o *github.IssuesEvent) []string {

This comment has been minimized.

@alexellis
@rajatjindal

This comment has been minimized.

Copy link
Owner Author

rajatjindal commented Feb 3, 2019

thanks for review Alex. I will hold on this one until I add atleast few basic tests. sometime today/tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment