Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for manual timer value #6

Merged
merged 1 commit into from Mar 5, 2023
Merged

Add button for manual timer value #6

merged 1 commit into from Mar 5, 2023

Conversation

sswart
Copy link
Contributor

@sswart sswart commented Feb 15, 2023

Adds an input and button to manually set the timer value.

I like to use 'uncommon' values like 7 minutes or so. With this change, instead of having to manually put it in the url, we can use the new input/button combination.

Few side notes:

  • It's not perfect, no real validation besides the input type
  • For numbers higher than 60, it uses the modulo 60 as its value (eg putting in 70 results in a 10 minute timer)

Copy link
Owner

@rajbos rajbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rajbos rajbos merged commit 9414e93 into rajbos:main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants